search

Serene-Arc / bulk-downloader-for-reddit

Downloads and archives content from reddit
https://pypi.org/project/bdfr
GNU General Public License v3.0
2.29k stars 211 forks source link

[BUG] Redgifs Error: Could not read the page source #358

Closed VulkanLogic closed 3 years ago

VulkanLogic commented 3 years ago

Description

First:

Here is what I did: Install Python3 with apt-get notice that this installs Python 3.8 Add ppa to be able to install Python 3.9 (deb http://ppa.launchpad.net/deadsnakes/ppa/ubuntu focal main) install Python 3.9 download git repository (as zip) and unpack (2.0.0) open terminal in unpacked folder and call: python3.9 setup.py There is an error because the Version is not reachable Use workaround and call PBR_VERSION=1.2.3 python3.9 setup.py sdist (provided version number does not matter for the installation) Normal downloads work, but not Redgifs I debugged it and found a solution that works.

Command

python3.9 -m bdfr download --no-dupes -s CollegeSluts ~/Downloads

Environment (please complete the following information):

Logs

did not find log file folder ~/.local/share/bdfr does not exist terminal output that shows the error: [2021-05-10 10:01:36,316 - bdfr.downloader - ERROR] - Site Redgifs failed to download submission n8fz5y: Could not read the page source

aliparlakci commented 3 years ago

This issue is actually fixed on the development branch. We just haven't released it to pip yet. You can download the source code from that branch and run your command inside the root directory of the project.

I will keep this issue open to be a reference until there is a new release with a fix.

Also, since you like the project and are eager to contribute to it, I encourage you to have a look at the redgifs.py so that you can have an understanding of how we fix these types of issues :)

https://github.com/aliparlakci/bulk-downloader-for-reddit/blob/development/bdfr/site_downloaders/redgifs.py

aliparlakci commented 3 years ago

Also, could you confirm that the log files are under ~/.config/bdfr?

VulkanLogic commented 3 years ago

Also, could you confirm that the log files are under ~/.config/bdfr?

Yes, that's the correct path.

aliparlakci commented 3 years ago

I will keep this issue open to be a reference until there is a new release with the fix.