Open gageirwin opened 1 year ago
Please read the bug and feature request forms. Where is this traceback from? What are the associated logs? Did this crash the BDFR or did it handle it and move on?
Where is this traceback from?
[2022-10-17 06:55:13,322 - bdfr.downloader - INFO] - Downloaded submission y5oj0l from battlestations
[2022-10-17 06:55:13,322 - bdfr.downloader - DEBUG] - Attempting to download submission y5oj0l
[2022-10-17 06:55:13,322 - bdfr.downloader - DEBUG] - Using Direct with url https://i.redd.it/agjmrxm8r7u91.jpg
[2022-10-17 07:11:15,278 - root - ERROR] - Downloader exited unexpectedly
What are the associated logs?
Did this crash the BDFR or did it handle it and move on?
This is my bad yes BDFR fully crashed when this occurred.
I have only noticed it happening with reddit hosted images so far. It's not consistent to reproduce as it doesn't seem to be a rate limit issue like I assumed.
I recognise I am bringing an old post to life, but I didn't see anything happen on this since 2022. I am also facing the same issue, BDFR times out and then crashes on some i.redd.it images.
I am using BDFR 2.7.0
Output from the most recent error, happy to provide more information/evidence as required:
[2024-04-03 20:18:18,951 - bdfr.downloader - DEBUG] - Attempting to download submission 1bruwpw [2024-04-03 20:18:18,951 - bdfr.downloader - DEBUG] - Using Direct with url https://i.redd.it/ilxpqaz2xjrc1.gif [2024-04-03 20:18:28,996 - root - ERROR] - Downloader exited unexpectedly - BDFR Downloader v2.7.0 Traceback (most recent call last):
File "C:\Program Files\Python310\lib\site-packages\urllib3\connectionpool.py", line 466, in _make_request
six.raise_from(e, None)
File "
During handling of the above exception, another exception occurred:
Traceback (most recent call last): File "C:\Program Files\Python310\lib\site-packages\requests\adapters.py", line 489, in send resp = conn.urlopen( File "C:\Program Files\Python310\lib\site-packages\urllib3\connectionpool.py", line 798, in urlopen retries = retries.increment( File "C:\Program Files\Python310\lib\site-packages\urllib3\util\retry.py", line 550, in increment raise six.reraise(type(error), error, _stacktrace) File "C:\Program Files\Python310\lib\site-packages\urllib3\packages\six.py", line 770, in reraise raise value File "C:\Program Files\Python310\lib\site-packages\urllib3\connectionpool.py", line 714, in urlopen httplib_response = self._make_request( File "C:\Program Files\Python310\lib\site-packages\urllib3\connectionpool.py", line 468, in _make_request self._raise_timeout(err=e, url=url, timeout_value=read_timeout) File "C:\Program Files\Python310\lib\site-packages\urllib3\connectionpool.py", line 357, in _raise_timeout raise ReadTimeoutError( urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='i.redd.it', port=443): Read timed out. (read timeout=10)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Program Files\Python310\lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "C:\Program Files\Python310\lib\runpy.py", line 86, in _run_code
exec(code, run_globals)
File "C:\Program Files\Python310\Scripts\bdfr.exe__main.py", line 7, in
Description
When downloading many submissions sometimes a
Connection timed out
will occur. In this instance it was when trying to download a i.redd.it image (image does exist). If you used a requests session instead of a straight requests call then you could use the sessions built in retry/back off functionality.Traceback: