Serene-Arc / bulk-downloader-for-reddit

Downloads and archives content from reddit
https://pypi.org/project/bdfr
GNU General Public License v3.0
2.3k stars 211 forks source link

[BUG] Some imgur gifv files get rejected with 404 because downloader used wrong url #921

Open staridiot opened 1 year ago

staridiot commented 1 year ago

Description

The downloader for Imgur seems to occasionally try to download some gifv files from https://api.imgur.com/3/image/x instead of https://i.imgur.com/x.gifv. The link works/exists at the time of writing this.

Command


Fair warning: These imgur links are NSFW, open at your discretion.

Works (https://i.imgur.com/N1nyc6i.gifv):
bdfr download ./test -v -l 15mb93a

Does not work (https://i.imgur.com/OfqW3bs.gifv):
bdfr download ./test -v -l 15mb2df

Environment (please complete the following information)

Logs

sysadmin@mediaserver:/test$ python3.9 -m bdfr download ./test -v -l 15mb93a
[2023-08-09 09:52:22,432 - bdfr.connector - DEBUG] - Disabling the following modules:
[2023-08-09 09:52:22,434 - bdfr.connector - DEBUG] - Using unauthenticated Reddit instance
Version 7.6.1 of praw is outdated. Version 7.7.1 was released Tuesday July 11, 2023.
[2023-08-09 09:52:22,696 - bdfr.downloader - DEBUG] - Attempting to download submission 15mb93a
[2023-08-09 09:52:22,697 - bdfr.downloader - DEBUG] - Using Imgur with url https://i.imgur.com/N1nyc6i.gifv
[2023-08-09 09:52:23,036 - bdfr.downloader - DEBUG] - Written file to /test/test/u_AzalyaStar/AzalyaStar_15mb93a.mp4
[2023-08-09 09:52:23,036 - bdfr.downloader - INFO] - Downloaded submission 15mb93a from u_AzalyaStar
[2023-08-09 09:52:23,036 - bdfr.downloader - DEBUG] - Hash added to master list: f6f90c0053a1c8a86b47d912b8b7d51f
[2023-08-09 09:52:23,036 - root - INFO] - Program complete
sysadmin@mediaserver:/test$ python3.9 -m bdfr download ./test -v -l 15mb2df
[2023-08-09 09:52:44,528 - bdfr.connector - DEBUG] - Disabling the following modules:
[2023-08-09 09:52:44,530 - bdfr.connector - DEBUG] - Using unauthenticated Reddit instance
Version 7.6.1 of praw is outdated. Version 7.7.1 was released Tuesday July 11, 2023.
[2023-08-09 09:52:44,820 - bdfr.downloader - DEBUG] - Attempting to download submission 15mb2df
[2023-08-09 09:52:44,820 - bdfr.downloader - DEBUG] - Using Imgur with url https://i.imgur.com/OfqW3bs.gifv
[2023-08-09 09:52:45,007 - bdfr.downloader - ERROR] - Site Imgur failed to download submission 15mb2df: Server responded with 404 to https://api.imgur.com/3/image/OfqW3bs
[2023-08-09 09:52:45,008 - root - INFO] - Program complete
Fakeaccount12312 commented 1 year ago

Just saying, both links don't work anymore.

ymgenesis commented 8 months ago

This is still an issue. When attempting to download this post: nsfw nudity, bdfr uses this link: and fails, looks like it's requesting authorization for access to the imgur api.

The first link (working at time of post) will probably be removed eventually as imgur doesn't allow nsfw anymore, I believe. Still, there are endless examples popping up everyday. There's a working link and it's not grabbing it correctly by trying to use the imgur api.

Serene-Arc commented 3 months ago

Hi, do you have a current example of this?