search

Serene-Arc / bulk-downloader-for-reddit

Downloads and archives content from reddit
https://pypi.org/project/bdfr
GNU General Public License v3.0
2.3k stars 211 forks source link

[BUG] Unable to download v.redd.it submissions #932

Closed LEARJS closed 9 months ago

LEARJS commented 1 year ago

Description

Whenever I try to download a submission containing v.redd.it source I get the same following error:

Failed to download resource https://v.redd.it/k7eckq67sbwb1 in submission 17g1mi8 with downloader VReddit: Youtube download failed: ERROR: You have requested merging of multiple formats but ffmpeg is not installed. Aborting due to --abort-on-error

It used to work just fine a few days ago but I tried today and it's rejecting all v.redd.it posts.

Command

python.exe -m bdfr download F --link https://www.reddit.com/r/Damnthatsinteresting/comments/17g1mi8/artificial_stone_process_with_concrete/ --config %LOCALAPPDATA%\bdfr\bdfr\default_config.cfg

Environment (please complete the following information)

Logs

[2023-10-25 08:46:41,969 - bdfr.connector - DEBUG] - Setting maximum download wait time to 120 seconds
[2023-10-25 08:46:41,970 - bdfr.connector - DEBUG] - Disabling the following modules: 
[2023-10-25 08:46:41,970 - bdfr.connector - Level 9] - Created download filter
[2023-10-25 08:46:41,971 - bdfr.connector - Level 9] - Created time filter
[2023-10-25 08:46:41,971 - bdfr.connector - Level 9] - Created sort filter
[2023-10-25 08:46:41,971 - bdfr.connector - Level 9] - Create file name formatter
[2023-10-25 08:46:41,971 - bdfr.connector - DEBUG] - Using unauthenticated Reddit instance
[2023-10-25 08:46:41,974 - bdfr.connector - Level 9] - Created site authenticator
[2023-10-25 08:46:41,974 - bdfr.connector - Level 9] - Retrieved subreddits
[2023-10-25 08:46:41,975 - bdfr.connector - Level 9] - Retrieved multireddits
[2023-10-25 08:46:41,975 - bdfr.connector - Level 9] - Retrieved user data
[2023-10-25 08:46:41,976 - bdfr.connector - Level 9] - Retrieved submissions for given links
[2023-10-25 08:46:44,766 - bdfr.downloader - DEBUG] - Attempting to download submission 17g1mi8
[2023-10-25 08:46:44,770 - bdfr.downloader - DEBUG] - Using VReddit with url https://v.redd.it/k7eckq67sbwb1
[2023-10-25 08:46:50,207 - bdfr.downloader - ERROR] - Failed to download resource https://v.redd.it/k7eckq67sbwb1 in submission 17g1mi8 with downloader VReddit: Youtube download failed: ERROR: You have requested merging of multiple formats but ffmpeg is not installed. Aborting due to --abort-on-error
[2023-10-25 08:46:50,207 - root - INFO] - Program complete
LEARJS commented 1 year ago

I would like to add that something similar is happening with Imgur nsfw posts. From what I noticed BDFR try to download from Imgur webpage link like this imgur.com/xxxxxx which often return 404 for nsfw since the purge, but if I were to access the same image through a direct link like this i.imgur.com/xxxxxx.mp4 then it's fully available to view and download. Most of the 404s I got where fully accessible when viewed the direct link to the image/video.

Serene-Arc commented 1 year ago

Thanks, looks like we need to update the module.

Fakeaccount12312 commented 12 months ago

Do you have ffmpeg installed and working well otherwise?

LEARJS commented 11 months ago

Do you have ffmpeg installed and working well otherwise?

Yes, it has been working correctly for months until this happened. This is only happening with Reddit videos, other sources don't face the same problem so ffmpeg isn't the issue here.

LEARJS commented 9 months ago

Any updates to mitigate the issue? It's been difficult since most of reddit moved to v.redd.it instead of gfycat/imgur.

Serene-Arc commented 9 months ago

Hi, I need the updated log with the relevant errors.

LEARJS commented 9 months ago

Here's another attempt I just tried right now. I double checked my ffmpeg files. I tried a clean install as well. The used command:

python.exe -m bdfr download F --link https://www.reddit.com/r/Damnthatsinteresting/comments/19acs81/who_knew_curling_sports_was_that_intense/ --config %LOCALAPPDATA%\bdfr\bdfr\default_config.cfg

The response: 

[2024-01-19 04:21:53,853 - bdfr.downloader - ERROR] - Failed to download resource https://v.redd.it/4b87xjfsdcdc1 in submission 19acs81 with downloader VReddit: Youtube download failed: ERROR: You have requested merging of multiple formats but ffmpeg is not installed. Aborting due to --abort-on-error

The logs: 

[2024-01-19 04:21:46,607 - bdfr.connector - DEBUG] - Setting maximum download wait time to 120 seconds
[2024-01-19 04:21:46,608 - bdfr.connector - DEBUG] - Setting datetime format string to ISO
[2024-01-19 04:21:46,609 - bdfr.connector - DEBUG] - Disabling the following modules: 
[2024-01-19 04:21:46,609 - bdfr.connector - Level 9] - Created download filter
[2024-01-19 04:21:46,610 - bdfr.connector - Level 9] - Created time filter
[2024-01-19 04:21:46,610 - bdfr.connector - Level 9] - Created sort filter
[2024-01-19 04:21:46,610 - bdfr.connector - Level 9] - Create file name formatter
[2024-01-19 04:21:46,610 - bdfr.connector - DEBUG] - Using unauthenticated Reddit instance
[2024-01-19 04:21:46,612 - bdfr.connector - Level 9] - Created site authenticator
[2024-01-19 04:21:46,612 - bdfr.connector - Level 9] - Retrieved subreddits
[2024-01-19 04:21:46,612 - bdfr.connector - Level 9] - Retrieved multireddits
[2024-01-19 04:21:46,612 - bdfr.connector - Level 9] - Retrieved user data
[2024-01-19 04:21:46,612 - bdfr.connector - Level 9] - Retrieved submissions for given links
[2024-01-19 04:21:49,053 - bdfr.downloader - DEBUG] - Attempting to download submission 19acs81
[2024-01-19 04:21:49,056 - bdfr.downloader - DEBUG] - Using VReddit with url https://v.redd.it/4b87xjfsdcdc1
[2024-01-19 04:21:53,853 - bdfr.downloader - ERROR] - Failed to download resource https://v.redd.it/4b87xjfsdcdc1 in submission 19acs81 with downloader VReddit: Youtube download failed: ERROR: You have requested merging of multiple formats but ffmpeg is not installed. Aborting due to --abort-on-error
[2024-01-19 04:21:53,854 - root - INFO] - Program complete
Serene-Arc commented 9 months ago

To be clear, you've installed ffmpeg from the website separately to the python bindings? You can call both?

LEARJS commented 9 months ago

Yes I can call ffmpeg. However, I think I solved the problem. I double checked PATH in system environment variables and it was directed correctly to the BDFR folder where I had put ffmpeg, I even re-applied the directory path to \bin folder to be sure but nothing changed. Then I thought about moving ffmpeg outside of BDFR folder and just throw them in C:\ffmpeg\bin then changed PATH to that and that somehow solved the problem! It's strange because the previous set up worked flawlessly until it stopped suddenly. So yeah I will mark this as solved.