Open trflynn89 opened 1 year ago
There is a very ominous note here: https://devcenter.heroku.com/articles/cli-style-guide#native-dependencies
Native dependencies The Heroku CLI does not support native dependencies. They will break when we update the node version. Also, native dependencies typically require the use of node-gyp, which requires Python, and generally is likely to have problems compiling on all user environments, especially Windows.
I'm not sure how this can be true, as... like the entire ecosystem depends on this stuff.
See 3c5e0ab210da30efce3dc11095bd15358c7c5daa
Node v18.18.0 includes an update to npm 9.7.2: https://github.com/nodejs/node/commit/4a6177daad59ec5bb4c29f10822d5a98655efe1a
That update removes the
node-gyp
executable. Without it, we get the following error when deploying the Heroku app:I'm not sure how do to the recommended step because this runs remotely in Heroku's servers (i.e. I don't think adding it as a step in the GitHub workflow will suffice).
For now, this has been worked around by limiting node to v18.17.1.