search

SerenityOS / discord-bot

Discord Bot for the Serenity Operating System Community 🐞
BSD 2-Clause "Simplified" License
31 stars 24 forks source link

feat: Add slapCommand to bring back the IRC vibe of trout slapping #1056

Open ADKaster opened 4 months ago

ADKaster commented 4 months ago

Also update to latest discord.js

ADKaster commented 4 months ago

@bgianfo @networkException halp, running yarn update discord.js (to get the latest nickname resolution changes from ~last year) is requesting node 18? How do I safely update discord.js and/or the CI/production bot?

networkException commented 4 months ago

uhh the thing is not stateful, right? not too much should go wrong. According to the docs updating the engines filed in the package.json should be enough (and it should already be on 20.x).

You might also have to adjust node versions in various github action workflows

ADKaster commented 4 months ago

it should already be on 20.x

Not according to this commit. https://github.com/SerenityOS/discord-bot/commit/3c5e0ab210da30efce3dc11095bd15358c7c5daa Looks like we pinned it to 18.17.1 due to some node-gyp error in the heroku install or something?

networkException commented 4 months ago

ah hm :/

bgianfo commented 4 months ago

I can add you to the heroku users so you can try to deploy this and rollback if it fails. Unfortunately there isn't a great way to try it out without creating a dev environment to try it out.