Open cg-jl opened 2 months ago
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!
shoo bot, is draft.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!
I started pulling the first thing that fixes binding common enum members and realized that we don't support it, so that one might have been me adding more code than necessary.
This is a collection of small changes that have made no performance impact, but that I have made to achieve better readability on the generated code. I originally intended to make these into a proper PR, but uni started hitting me and it won't stop for at least one month more.
I don't intend to merge these changes as-is, but there are some things that we might want to pull from, or may serve as a list of low-hanging fruits for other devs to get into the weeds. I'll be separating the couple of changes that fix bugs I found in the codegen so they can be put into a different PR and properly merged.
codegen: Disable use of TRY() macro when returning from a throwing function#1569codegen: Avoid generating forward namespace if nothing is inside#1569codegen: Use temporary variable only for yielding from try#1569codegen: Change accessor when binding a common enum member FIXES BUG#1569typecheck: Search for common fields in non-StructLike pattern arguments FIXES BUG#1569codegen: Use the correct name to search for common enum members FIXES BUG#1569