Closed cg-jl closed 3 months ago
🤔 you can declare functions as variadic, why not add extern fn appendff(mut this, anon format: StringView, ..) -> void
?
oh, I searched through the samples and didn't find any tests so I thought you had dropped them! That is much easier 😉
I'm pretty bad at adding tests for things I add "on the way" to a different feature... oops!
Glad the tests run under Windows. My build is broken under Windows; the linker shows garbage errors about StaticDebug
and StaticRelease
mixed with bad encoding:
The garbage is probably due to an encoding mishap since we use SetConsoleOutputCp(UTF8)
and lld-link probably expects it to stay as UTF16
.
This way we can remove a lot of duplicated effort where we format into a String to then copy the string directly to the StringBuffer.
The parser had a little choke, where it would error in the rparen after varargs:
..)
. It thought it had just passed over a comma, which was the only possible case until now.runtime/prelude.jakt
hasappendff
which is the test for it passing.