Open skyrising opened 2 years ago
Looks like TypedArray.prototype.at
is already implemented here https://github.com/SerenityOS/serenity/blob/4fd463dae0e2e8117f0cd672b9186680095b4f82/Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp#L177-L195
True, just at the moment the deployed version checks for it incorrectly. It's fixed in their dev version: https://github.com/github/browser-support/commit/35e239009a974dd64338d88869d4524b9f7aabbc#diff-5777b02de15b15d9086896277beb792f1646303f68d3ddd2d5cfd7ff8418d140L17-R19
I've implemented enough of custom elements to make GitHub JS progress and it now requires these:
Unhandled JavaScript exception: [TypeError] undefined is not a function (evaluated from '<object>.attachShadow')
o at https://github.githubassets.com/assets/vendors-node_modules_github_filter-input-element_dist_index_js-node_modules_github_remote-inp-73b750-38f5b4798267.js:1:20909
(global execution context) at :0:0
Unhandled JavaScript exception: [InternalError] TODO(Generator function execution in AST interpreter is not implemented in LibJS)
$ at https://github.githubassets.com/assets/vendors-node_modules_fzy_js_index_js-node_modules_github_catalyst_lib_index_js-f695bb26145e.js:1:3167
_ at https://github.githubassets.com/assets/vendors-node_modules_fzy_js_index_js-node_modules_github_catalyst_lib_index_js-f695bb26145e.js:1:3168
C at https://github.githubassets.com/assets/vendors-node_modules_fzy_js_index_js-node_modules_github_catalyst_lib_index_js-f695bb26145e.js:1:2472
O at https://github.githubassets.com/assets/vendors-node_modules_fzy_js_index_js-node_modules_github_catalyst_lib_index_js-f695bb26145e.js:1:1834
connectedCallback at https://github.githubassets.com/assets/vendors-node_modules_fzy_js_index_js-node_modules_github_catalyst_lib_index_js-f695bb26145e.js:1:6254
<unknown> at https://github.githubassets.com/assets/vendors-node_modules_fzy_js_index_js-node_modules_github_catalyst_lib_index_js-f695bb26145e.js:1:5701
(global execution context) at :0:0
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:1:15705
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:1:15740
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:1:15740
39585 at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:1:15687
<unknown> at https://github.githubassets.com/assets/runtime-bdb9fcc41360.js:1:230
t at https://github.githubassets.com/assets/runtime-bdb9fcc41360.js:1:253
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:98:2164
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:98:3324
<unknown> at https://github.githubassets.com/assets/runtime-bdb9fcc41360.js:1:622
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:98:3341
<unknown> at https://github.githubassets.com/assets/runtime-bdb9fcc41360.js:2:250
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:98:2143
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:1:2
(global execution context) at :0:0
Unhandled JavaScript exception: [ReferenceError] 'fetch' is not defined
send at https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_github_hotkey_dist_index-9f48bd-dd2ca854f808.js:1:5592
sendEvent at https://github.githubassets.com/assets/vendors-node_modules_github_mini-throttle_dist_index_js-node_modules_github_hotkey_dist_index-9f48bd-dd2ca854f808.js:1:5375
e at https://github.githubassets.com/assets/app_assets_modules_github_behaviors_keyboard-shortcuts-helper_ts-app_assets_modules_github_di-9b8a64-f8d200d587ca.js:1:7881
data at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:1:990
<unknown> at https://github.githubassets.com/assets/vendors-node_modules_delegated-events_dist_index_js-node_modules_github_details-dialog-elemen-63debe-74ce3589143a.js:1:5378
k at https://github.githubassets.com/assets/vendors-node_modules_delegated-events_dist_index_js-node_modules_github_details-dialog-elemen-63debe-74ce3589143a.js:1:5386
(global execution context) at :0:0
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:1:15705
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:1:15740
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:1:15740
39585 at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:1:15687
<unknown> at https://github.githubassets.com/assets/runtime-bdb9fcc41360.js:1:230
t at https://github.githubassets.com/assets/runtime-bdb9fcc41360.js:1:253
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:98:2164
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:98:3324
<unknown> at https://github.githubassets.com/assets/runtime-bdb9fcc41360.js:1:622
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:98:3341
<unknown> at https://github.githubassets.com/assets/runtime-bdb9fcc41360.js:2:250
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:98:2143
<unknown> at https://github.githubassets.com/assets/behaviors-cc157767d2d6.js:1:2
(global execution context) at :0:0
It looks like their base support removed a bunch of pollyfills a few weeks ago. Anyone up for updating the list?
https://github.com/github/browser-support/commit/ee56483410a1b8bedb31940dd8683435aa03eab1
Undocumented, but it now uses the popover(target) attributes, see https://github.com/SerenityOS/serenity/issues/23410
GitHub checks for a bunch of features to determine if a browser is supported.
You can see these checks yourself at https://github.com/github/browser-support/blob/main/src/index.ts. However this might not exactly match the deployed version, which you can see in browser dev-tools through source maps at
assets/node_modules/@github/browser-support/lib/index.js
Base support:
Polyfilled:
Required features without feature tests: