search

SerenityOS / serenity

The Serenity Operating System 🐞
https://serenityos.org
BSD 2-Clause "Simplified" License
30.64k stars 3.2k forks source link

FontEditor: Verify if glyph U+FFFD exists in loaded font file #13672

Closed djwisdom closed 2 years ago

djwisdom commented 2 years ago

This feature will aid in ensuring that mandatory glyph exists as recommended on http://wiki.serenityos.net/fonts.html under section Creating a font.

Font Editor can display dialog box informing user of the situation. Font Editor can also add the words *MISSING U+FFFD GLYPH" on the application status bar or title bar wherever which location makes sense.

Xexxa commented 2 years ago

U+FFFD � falls back on U+003F ? if it does not exist.

Because it's our primary .notdef glyph I consider it "mandatory". That's why it's in the wiki and clearly labeled on https://fonts.serenityos.net/LizaBlack10, I draw that conclusion from the source code

IIRC there has been talk in our community about replacing the replacement character with something else, couldn't find the discussion after a quick look. But the replacement character is primary used for encoding errors nowadays according to wikipedia.

So, until we know if FFFD has a future I'm not sure if it's worth implementing. ¯_(ツ)_/¯

djwisdom commented 2 years ago

Sounds good to me. Closing issue.