Spreadsheet: Some (?) JS errors crash Spreadsheet

To reproduce:

use this file (your sheet cannot be empty, and this one reproduces consistently):

spreadsheet file contents

``` [{"name":"Calculation","rows":6,"cells":{"K4":{"kind":"Formula","source":"D4*A3/F4","value":"249.62158203125","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"B0":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"K6":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"F5": {"kind":"Formula","source":"481*1024","value":"492544","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"I3":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"E4":{"kind":"LiteralString","value":"94","type":"Numeric","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"E3":{"kind":"LiteralString","value":"187","type":"Numeric","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"A2":{"kind":"LiteralString","value":"Amount of data (bytes)","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterLeft"},"conditional_formats":[],"evaluated_formats":{}},"B6":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"J3":{"kind":"Formula","source":"H3*A3/F3/1000","value":"3678826.222500000149011","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"C3":{"kind":"LiteralString","value":"83","type":"Numeric","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"D2": {"kind":"LiteralString","value":"Height (mm)","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"B3":{"kind":"LiteralString","value":"Hollerith punch cards","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"B2":{"kind":"LiteralString","value":"Medium","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"B5":{"kind":"LiteralString","value":"large floppys","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"B4": {"kind":"LiteralString","value":"small floppys","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"K3":{"kind":"Formula","source":"D3*A3/F3","value":"237022.5","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"H6":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"C2":{"kind":"LiteralString","value":"Width (mm)","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"G3": {"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"G2":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"F4":{"kind":"Formula","source":"1440*1024","value":"1474560","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"E6":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"J5":{"kind":"Formula","source":"H5*A3/F5/1000","value":"12629.502744932431596","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"J9": {"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"J6":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"E7":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"A3":{"kind":"LiteralString","value":"111540000","type":"Numeric","type_metadata":{"length":-1,"format":null,"alignment":"CenterLeft"},"conditional_formats":[],"evaluated_formats":{}},"K5":{"kind":"Formula","source":"D5*A3/F5","value":"747.307854729729683","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"H4":{"kind":"Formula","source":"C4*D4*E4","value":"27918","type":"Identity","type_metadata": {"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"I2":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"J2":{"kind":"LiteralString","value":"SerenityOS volume (cm³)","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"A1":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"E2":{"kind":"LiteralString","value":"Length (mm)","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"D6":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"F3":{"kind":"LiteralString","value":"80","type":"Numeric","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"H5":{"kind":"Formula","source":"C5*D5*E5","value":"55770","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"D4": {"kind":"LiteralString","value":"3.3","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"C5":{"kind":"LiteralString","value":"130","type":"Numeric","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"C6":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"B1":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"C1": {"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"A4":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"F2":{"kind":"LiteralString","value":"Capacity (bytes)","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"D3":{"kind":"LiteralString","value":"0.17","type":"Numeric","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"F6":{"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"K2":{"kind":"LiteralString","value":"SerenityOS height (mm)","type":"Identity","type_metadata": {"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"C4":{"kind":"LiteralString","value":"90","type":"Numeric","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"J4":{"kind":"Formula","source":"H4*A3/F4/1000","value":"2111.798583984375","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"H2":{"kind":"LiteralString","value":"Volume (mm³)","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"A0":{"kind":"LiteralString","value":"Calculations for how much volume SerenityOS takes up in physical containers","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"H3":{"kind":"Formula","source":"C3*D3*E3","value":"2638.570000000000163","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"G4": {"kind":"LiteralString","value":"","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"E5":{"kind":"LiteralString","value":"130","type":"Numeric","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}},"D5":{"kind":"LiteralString","value":"3.3","type":"Identity","type_metadata":{"length":-1,"format":null,"alignment":"CenterRight"},"conditional_formats":[],"evaluated_formats":{}}}}] ```

type anything in a Spreadsheet cell after the = that creates a JS error (like the start of a cell name, it's consistent with =C)

crash

==== Thread #0 (TID 53) ====
0x000000119940f14f: [/usr/lib/libjs.so.serenity] JS::Error::populate_stack() +0x9f (RefCounted.h:31 => NonnullRefPtr.h:31 => RefPtr.h:45 => FlyString.h:18 => Error.cpp:61)
0x0000001199410732: [/usr/lib/libjs.so.serenity] JS::ReferenceError::create(JS::GlobalObject&, AK::String const&) +0x82 (Error.cpp:34 => Error.cpp:119 => Heap.h:48)
0x00000011995161d2: [/usr/lib/libjs.so.serenity] JS::Reference::throw_reference_error(JS::GlobalObject&) const [clone .localalias] +0x1b2 (VM.h:173 => VM.h:179 => Reference.cpp:83)
0x0000001199516d84: [/usr/lib/libjs.so.serenity] JS::Reference::get_value(JS::GlobalObject&) const +0x54 (Reference.cpp:94)
0x00000011992d1ac8: [/usr/lib/libjs.so.serenity] JS::Identifier::execute(JS::Interpreter&, JS::GlobalObject&) const +0xe8 (AST.cpp:2486)
0x00000011992c4424: [/usr/lib/libjs.so.serenity] JS::ExpressionStatement::execute(JS::Interpreter&, JS::GlobalObject&) const +0x94 (AST.cpp:328)
0x00000011992cfee5: [/usr/lib/libjs.so.serenity] JS::ScopeNode::evaluate_statements(JS::Interpreter&, JS::GlobalObject&) const +0x85 (AST.cpp:97)
0x00000011992d00e2: [/usr/lib/libjs.so.serenity] JS::Program::execute(JS::Interpreter&, JS::GlobalObject&) const +0x82 (AST.cpp:246)
0x00000011993449f0: [/usr/lib/libjs.so.serenity] JS::Interpreter::run(JS::Script&) +0x520 (Interpreter.cpp:90)
0x00000009a6e13b09: [/bin/Spreadsheet] Spreadsheet::Sheet::evaluate(AK::StringView, Spreadsheet::Cell*) +0xb9 (Spreadsheet.cpp:173)
0x00000009a6de171a: [/bin/Spreadsheet] Spreadsheet::Cell::update_data(AK::Badge<Spreadsheet::Sheet>) +0x15a (Cell.cpp:103)
0x00000009a6e13efe: [/bin/Spreadsheet] Spreadsheet::Sheet::update(Spreadsheet::Cell&) [clone .part.0] +0x1de (Spreadsheet.cpp:161)
0x00000009a6e1419a: [/bin/Spreadsheet] Spreadsheet::Sheet::update() +0x23a (Error.h:117 => Spreadsheet.cpp:142)
0x00000009a6e300f1: [/bin/Spreadsheet] AK::Function<void ()>::CallableWrapper<Spreadsheet::SpreadsheetWidget::setup_tabs(AK::NonnullRefPtrVector<Spreadsheet::Sheet, 0ul>)::{lambda(AK::Vector<Spreadsheet::Position, 0ul>&&)#3}::operator()(AK::Vector<Spreadsheet::Position, 0ul>&&) const::{lambda()#1}>::call() +0xc1 (SpreadsheetWidget.cpp:318 => Function.h:151)
0x000000141f048e8f: [/usr/lib/libgui.so.serenity] GUI::TextEditor::did_change(GUI::AllowCallback) [clone .localalias] +0xcf (Function.h:91)
0x000000141f04a137: [/usr/lib/libgui.so.serenity] non-virtual thunk to GUI::TextEditor::document_did_change(GUI::AllowCallback) [clone .localalias] +0x17 (TextEditor.h:266)
0x000000141f033f7e: [/usr/lib/libgui.so.serenity] GUI::TextDocument::notify_did_change() [clone .localalias] +0x5e (TextDocument.cpp:310)
0x000000141f0386a8: [/usr/lib/libgui.so.serenity] GUI::TextDocument::insert_at(GUI::TextPosition const&, unsigned int, GUI::TextDocument::Client const*) [clone .localalias] +0x58 (TextDocument.cpp:954)
0x000000141f038ad0: [/usr/lib/libgui.so.serenity] GUI::TextDocument::insert_at(GUI::TextPosition const&, AK::StringView, GUI::TextDocument::Client const*) +0x60 (TextDocument.cpp:940)
0x000000141f038d7e: [/usr/lib/libgui.so.serenity] GUI::InsertTextCommand::redo() +0x4e (TextDocument.cpp:839)
0x000000141f04a357: [/usr/lib/libgui.so.serenity] GUI::TextEditor::insert_at_cursor_or_replace_selection(AK::StringView) [clone .localalias] +0x197 (TextDocument.h:203 => TextEditor.h:345 => TextEditor.cpp:1445)
0x000000141f04a957: [/usr/lib/libgui.so.serenity] GUI::TextEditor::add_code_point(unsigned int) [clone .part.0] +0xb7 (TextEditor.cpp:1032)
0x000000141f04ad8d: [/usr/lib/libgui.so.serenity] GUI::TextEditor::keydown_event(GUI::KeyEvent&) +0x37d (TextEditor.cpp:1020 => TextEditor.cpp:937)
0x000000141f07335c: [/usr/lib/libgui.so.serenity] GUI::Widget::handle_keydown_event(GUI::KeyEvent&) +0x2c (Widget.cpp:324)
0x00000006e1d7d35a: [/usr/lib/libcore.so.serenity] Core::Object::dispatch_event(Core::Event&, Core::Object*) +0x8a (Object.cpp:220)
0x000000141f089fd4: [/usr/lib/libgui.so.serenity] GUI::Window::event(Core::Event&) [clone .localalias] +0xc4 (Window.cpp:631)
0x00000006e1d7d35a: [/usr/lib/libcore.so.serenity] Core::Object::dispatch_event(Core::Event&, Core::Object*) +0x8a (Object.cpp:220)
0x00000006e1d6795b: [/usr/lib/libcore.so.serenity] Core::EventLoop::pump(Core::EventLoop::WaitMode) +0x15b (EventLoop.cpp:470)
0x00000006e1d68279: [/usr/lib/libcore.so.serenity] Core::EventLoop::exec() +0x119 (EventLoop.cpp:427)
0x00000009a6e3a2a7: [/bin/Spreadsheet] serenity_main(Main::Arguments) +0x547 (main.cpp:80)
0x00000009a6de0bda: [/bin/Spreadsheet] main +0x9a (Main.cpp:39)
0x00000009a6de0e0f: [/bin/Spreadsheet] _entry +0x6f (crt0.cpp:49)

cc @alimpfard

SerenityOS / serenity

Spreadsheet: Some (?) JS errors crash Spreadsheet #14042