RequestServer+LibGemini: Could not load any of the gemini sites I tried

[hjalves]

I tried to load the following 4 gemini websites:

1. gemini://gemini.circumlunar.space
2. gemini://geminispace.info
3. gemini://flounder.online
4. gemini://mozz.us

They all refused to load or crashed with different errors:

1. gemini://gemini.circumlunar.space - refused to load

33.785 RequestServer(49:49): We were alerted of a critical error: 40 (HandshakeFailure)
33.790 RequestServer(49:49): Possible failure cause(s): 
33.790 RequestServer(49:49): - No cipher suite in common with gemini.circumlunar.space

2. gemini://geminispace.info - refused to load

83.249 RequestServer(55:55): verify_chain: Non-root self-signed certificate
83.249 RequestServer(55:55): certificate verification failed :(
83.249 RequestServer(55:55): null secret
83.249 RequestServer(55:55): Possible failure cause(s): 
83.249 RequestServer(55:55): - No one knows.
83.249 RequestServer(55:55): ConnectionCache: Connection to gemini://geminispace.info failed: BadCertificate

3. gemini://flounder.online - refused to load

162.440 RequestServer(61:61): We were alerted of a critical error: 40 (HandshakeFailure)
162.444 RequestServer(61:61): Possible failure cause(s): 
162.444 RequestServer(61:61): - No cipher suite in common with flounder.online

4. gemini://mozz.us - crashed

247.893 RequestServer(67:67): certificate request
248.171 RequestServer(67:67): ASSERTION FAILED: !_temporary_result.is_error()

[alimpfard]

• gemini.circumlunar.space switched to ECDHE+ECDSA a while back, that's WIP
• geminispace.info should work, but looks like we're rejecting self-signed certs now (cc @msvisser I think you rewrote this part recent-ishly)
• flounder.online is probably in the same boat as gemini.circumlunar.space
• mozz.us: can you provide a backtrace?

[msvisser]

• For both gemini.circumlunar.space and flounder.online only ECDSA is supported, which is currently not supported by SerenityOS. I did some work on ECDSA (#13163), but it is nowhere near finished for actual inclusion.
• For geminispace.info there is the TLS option allow_self_signed_certificates, however it is currently never set. For testing you could change the default value. I will have a look if I can enable self signed certificates automatically for Gemini. However, even with this option on, Gemini support seems broken as no page ever loads for me.
• mozz.us breaks somewhere on set_downloaded_size(MUST(const_cast<Core::Stream::File&>(this->output_stream()).size()));

  669.636 CrashReporter(45:49): 0x00000015f19c802b: [/usr/lib/libsystem.so] syscall2 +0xb (syscall.cpp:25 => syscall.cpp:24)
  669.636 CrashReporter(45:49): 0x00000015376e9b76: [/usr/lib/libc.so] abort +0x26 (stdlib.cpp:223)
  669.636 CrashReporter(45:49): 0x00000015376ee8ae: [/usr/lib/libc.so] __assertion_failed +0x7e (assert.cpp:33)
  669.636 CrashReporter(45:49): 0x000000117b45c52b: [/bin/RequestServer] RequestServer::GeminiRequest::GeminiRequest(RequestServer::ConnectionFromClient&, AK::NonnullRefPtr<Gemini::Job>, AK::NonnullOwnPtr<Core::Stream::File>&&)::{lambda(bool)#1}::operator()(bool) const +0x66b (GeminiRequest.cpp:24)
  669.636 CrashReporter(45:49): 0x0000000204545477: [/usr/lib/libcore.so.serenity] AK::Function<void (bool)>::operator()(bool) const +0x47 (Function.h:91)
  669.636 CrashReporter(45:49): 0x00000002045451f3: [/usr/lib/libcore.so.serenity] Core::NetworkJob::did_finish(AK::NonnullRefPtr<Core::NetworkResponse>&&) +0xa3 (NetworkJob.cpp:39)
  669.636 CrashReporter(45:49): 0x00000013858a1748: [/usr/lib/libgemini.so.serenity] AK::Function<void ()>::CallableWrapper<Gemini::Job::finish_up()::{lambda()#2}>::call() +0x48 (Job.cpp:223 => Function.h:151)
  669.640 CrashReporter(45:49): 0x0000000204547d5c: [/usr/lib/libcore.so.serenity] AK::Function<void ()>::CallableWrapper<Core::Object::deferred_invoke(AK::Function<void ()>)::{lambda()#1}>::call() +0x23c (Function.h:91)
  669.640 CrashReporter(45:49): 0x00000002045318e1: [/usr/lib/libcore.so.serenity] Core::EventLoop::pump(Core::EventLoop::WaitMode) [clone .localalias] +0x2a1 (Function.h:91)
  669.640 CrashReporter(45:49): 0x00000002045320b9: [/usr/lib/libcore.so.serenity] Core::EventLoop::exec() +0x119 (EventLoop.cpp:427)
  669.640 CrashReporter(45:49): 0x000000117b4677f2: [/bin/RequestServer] serenity_main(Main::Arguments) +0x1a2 (main.cpp:51)
  669.640 CrashReporter(45:49): 0x000000117b43b98a: [/bin/RequestServer] main +0x9a (Main.cpp:39)
  669.640 CrashReporter(45:49): 0x000000117b43bbbf: [/bin/RequestServer] _entry +0x6f (crt0.cpp:49)