Open JonJFineman opened 1 year ago
This crash would have to be reduced further to be of much use. Currently this can't be reproduced (possibly because the site has changed since you used it).
It is still crashing for me today. Same Serenity commit. It appears to be that AK::Optional
I couldn't get a gdb prompt for a backtrace. Any guidance on how to do that, beyond what is in the build page?
ResourceLoader: Finished load of: "https://www.cnn.com/data/ocs/container/coverageContainer_CF35AF62-73C4-1733-9591-89FC773A9320:list-hierarchical-horizontal-simple/views/containers/common/container-manager.html", Duration: 14136ms
ResourceLoader: Finished load of: "https://www.cnn.com/data/ocs/container/coverageContainer_70CCAD23-FDEF-8E85-D427-7081AEFAB605:list-small-horizontal/views/containers/common/container-manager.html", Duration: 14520ms
ResourceLoader: Starting load of: "https://cdn.cnn.com/cnnnext/dam/assets/221117142556-the-assignment-with-audie-cornish-large-169.jpg"
ResourceLoader: Finished load of: "https://www.cnn.com/data/ocs/container/coverageContainer_8C4FF4C7-3E30-1ABB-5B13-C072E64EDA38:list-hierarchical-xs/views/containers/common/container-manager.html", Duration: 14752ms
ResourceLoader: Starting load of: "https://cdn.cnn.com/cnnnext/dam/assets/230127163624-disney-world-magic-kingdom-park-file-restricted-large-169.jpg"
ResourceLoader: Finished load of: "https://cdn.cnn.com/ads/cnn/singles/cnn_entitlement_hp_01.js", Duration: 14792ms
ResourceLoader: Finished load of: "https://cdn.cnn.com/cnnnext/dam/assets/230127163624-disney-world-magic-kingdom-park-file-restricted-large-169.jpg", Duration: 516ms
ResourceLoader: Finished load of: "https://cdn.cnn.com/cnnnext/dam/assets/221117142556-the-assignment-with-audie-cornish-large-169.jpg", Duration: 780ms
ResourceLoader: Finished load of: "https://data.cnn.com/breaking_news/domestic.json", Duration: 5936ms
WebContent: /home/jjf/src/serenity/AK/Optional.h:215: T& AK::Optional
It's a bit tricky to get a GDB backtrace from ladybird due to it's multi process design. You have to set a breakpoint before it forks to create the WebContent process then do set follow-fork-mode child
. Then you'll actually be debugging WebContent/LibWeb (rather than the Qt app or the SQL server).
Anyway, the usual way to tackle things like this is to reduce the crash down into a little HTML snippet that you can easily debug yourself, or just attach to the issue (which can take a little while to do depending on the crash).
Using ladybird on Debian.
Debian Linux laptop 6.1.0-2-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.7-1 (2023-01-18) x86_64 GNU/Linux commit 609a89cfb0819126c61d49e0b3bf3be38b833c35 (HEAD -> master, origin/master, origin/HEAD)
It would be nice if the video player crashing was treating as a warning and not a fatal error.
Trying to load www.cnn.com I got the following:
(snip) Unhandled JavaScript exception: [TypeError] undefined is not a function (evaluated from 'e.play')