search

SerenityOS / serenity

The Serenity Operating System 🐞
https://serenityos.org
BSD 2-Clause "Simplified" License
30.63k stars 3.19k forks source link

LibGUI: TextEditor+TextBox don't respect is_enabled(). #1987

Closed zlotny closed 4 years ago

zlotny commented 4 years ago

For example now FileManager/PropertiesDialog has to rely on manually preventing the user writing on the TextBox to act like it's disabled, which is not ideal.

awesomekling commented 4 years ago

Both TextEditor and TextBox inherit set_enabled(bool) from GUI::Widget.

They probably need to respect the is_enabled() state better though :)

zlotny commented 4 years ago

You're right :). Reworded

zlotny commented 4 years ago

Well, they indeed respect is_enabled() at least in what focus and writing is related. What they didn't do is change the colour to better inform the user they won't do anything.

This is improved by PR #1996