LibWeb: Something is wrong with height calculation inside flex item

kalenikaliaksandr commented 1 year ago

Reduction from https://linktr.ee/katalinkult:

<!DOCTYPE html><style type="text/css">
  * {
    border: 1px solid black;
  }
  .flex-item {
    flex-grow: 1;
  }
  .box {
    height: 100%;
  }
  .flex-container {
    display: flex;
    min-height: 100px;
    flex-direction: column;
  }
</style><div class="flex-container"><div class="flex-item"><div class="box">I make music you can dream to.</div><div>My SoundCloud</div></div></div>

Funding

We're currently trying Polar.sh where you can help fund the work on this issue.
Contributor(s) receive the funding once the issue is completed & confirmed.

tcl3 commented 5 months ago

The reduction now renders correctly for me.

The commit that fixed this appears to be f963bb4f3632358a79fc3744ee7c8eb141e1662b.

Does that mean this issue can be closed?

awesomekling commented 5 months ago

Oh hey, nice that we got it fixed. Yes, then we can close it! :)

SerenityOS / serenity

LibWeb: Something is wrong with height calculation inside flex item #21054

Funding