search

SerenityOS / serenity

The Serenity Operating System 🐞
https://serenityos.org
BSD 2-Clause "Simplified" License
29.46k stars 3.14k forks source link

Calculator: Add c constant #24576

Open skylar-eng opened 2 weeks ago

skylar-eng commented 2 weeks ago

I have added the "c" constant to the calculator This is the speed of light in a vacuum, 299,792,458 metres/second. I Figured it would be an interesting thing to have added.

I also have created a quick and dirty c icon, that should be replaced. It should be considered a placeholder for now.

BuggieBot commented 2 weeks ago

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

skylar-eng commented 2 weeks ago

image

the WIP icon

skylar-eng commented 2 weeks ago

Welcome to the project!

There are several issues that prevent the commit to be merged as is:

  • There are issues with your commit message, that's why the CI is failing. You can look at the details to see what's wrong.

  • You didn't add the image to the repo, so the code you submitted will make the Calculator crash on startup. That being said, I would rather not have an icon that having a "quick and dirty" one. The icon could be added later on.

To apply any of these, please fix up the modification in the current commit rather than adding a new one / creating a new PR. Don't hesitate to ask on Discord for help.

Thank you! I will be sure to look and make these changes when I am back at my computer, in a couple of hours.