search

SerenityOS / serenity

The Serenity Operating System 🐞
https://serenityos.org
BSD 2-Clause "Simplified" License
29.32k stars 3.13k forks source link

PixelPaint: Fixed some Color Masking issues #24580

Closed Torstennator closed 4 days ago

Torstennator commented 1 week ago

This change fixes an issue where pixelpaint was crashing when trying to refine an editing mask with the "Color Masking" feature because we where accessing pixel coordinates that where beyond the boundaries. Furthermore a change was made to make the color masking hue selection work again with mouse clicks directly on the color wheel.

BuggieBot commented 1 week ago

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

nico commented 1 week ago

https://github.com/SerenityOS/serenity/blob/master/CONTRIBUTING.md#code-submission-policy

Write the commit message subject line in the imperative mood ("Foo: Change the way dates work", not "Foo: Changed the way dates work").

And since it's two independent things, maybe it should be two commits?

Otherwise looks good, thanks for the PR!

nico commented 4 days ago

Thanks!