search

SerenityOS / serenity

The Serenity Operating System 🐞
https://serenityos.org
BSD 2-Clause "Simplified" License
29.64k stars 3.15k forks source link

Grammar fixes #24648

Closed ryancdotorg closed 3 days ago

ryancdotorg commented 3 days ago

There are a few instances where comments and documentation have minor grammar issues likely resulting from English being the author's second language.

This PR fixes several such cases, changing to idiomatic English and resolving where it is unclear whether the user or program/code is being referred to.

BuggieBot commented 3 days ago

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why. Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

sylv256 commented 3 days ago

Thank you! In my opinion, this would make the project a lot more neutral-toned and less controversial.

gmta commented 3 days ago

Please fix the commit messages (see BuggieBot's comment); and maybe this can go in one commit? Doesn't really need to be 5 separate ones.

ryancdotorg commented 3 days ago

Sure, I'll squash and force push in about an hour.

On July 2, 2024 1:12:12 PM PDT, Jelle Raaijmakers @.***> wrote:

Please fix the commit messages (see BuggieBot's comment); and maybe this can go in one commit? Doesn't really need to be 5 separate ones.

lavenderdotpet commented 3 days ago

hell yeah! <3

BertalanD commented 3 days ago

Two more commit title nitpicks and we're good to go:

From CONTRIBUTING.md:

Write the commit message subject line in the imperative mood ("Foo: Change the way dates work", not "Foo: Changed the way dates work").

Thanks!

ryancdotorg commented 3 days ago

@BertalanD Look good now?

ryancdotorg commented 3 days ago

Thanks all!

LiEnby commented 3 days ago

yeah of course can't have people of other genders existing thats too "political"

ryancdotorg commented 3 days ago

Folks, please assume good faith here, and do not brigade this thread.

LiEnby commented 3 days ago

Folks, please assume good faith here, and do not brigade this thread.

no, the maintainers constantly acting in bad faith constantly throughout this entire fucking thing.

ryancdotorg commented 3 days ago

@LiEnby This PR has been merged. Please don't complain about the locked PRs/issues in my notifications. There are better outlets.

LiEnby commented 3 days ago

maybe try not claiming acknowleding other people's mere existence is "poltiical* and 'controversal'..,

.. it's only merged because it doesn't acknowledge other people exist.

ryancdotorg commented 3 days ago

@LiEnby

  1. I'm not involved in SerenityOS.
  2. I created this PR fixing the grammar errors.
  3. The PR has been merged.
  4. I'm a trans enby suing the British government for more gender, please do not lecture me about politics.
LiEnby commented 3 days ago

4. I'm a trans enby suing the British government for more gender, please do not lecture me about politics.

see this is exactly the problem your once again validating that somehow the mere existence of trans people / neutral pronouns is 'politics'

ryancdotorg commented 3 days ago

@LiEnby Others have made it so... for now. Eventually it will not be. I will not be engaging with you here further, out of respect for the maintainer's notifications. My contact information for other platforms is easy to find if you still want to talk about it.

LiEnby commented 3 days ago

no - the existence of other people is not political.

also maintainers have made it clear their a transphobic peice of shit so i don't really give a shit about that tbh

ADKaster commented 3 days ago

@LiEnby Previous discussions were closed due to inflammatory rhetoric. No matter the topic being discussed or points being made, that kind of heated flame war has no place on our issue tracker or pull request queue. Please discuss this elsewhere.

BertalanD commented 3 days ago

I was so happy that we could keep this PR's discussion civil and bring a definitely positive change into our code base.

This is why we can't have nice things.

LiEnby commented 3 days ago

@LiEnby Previous discussions were closed due to inflammatory rhetoric. No matter the topic being discussed or points being made, that kind of heated flame war has no place on our issue tracker or pull request queue. Please discuss this elsewhere.

yes yes i know acknowledging gender neutral pronouns and people who aren't men exist is ""inflammatory"" and "heated flame war" it's only acceptable if you pretend they aren't real because their mere existence is """controversal""" and """polticial""" .. right?

ADKaster commented 3 days ago

If the discussion three years after the fact in https://github.com/SerenityOS/serenity/pull/6814 is not a flame war I don't know what is. Stop assuming bad faith and projecting the worst possible interpretation of events because we closed GitHub items where people were clearly brigading and not acting in good faith