LibWeb: OOPWV View Source doesn't work with big documents

SerenityOS / serenity

The Serenity Operating System 🐞

https://serenityos.org

BSD 2-Clause "Simplified" License

30.45k stars 3.18k forks source link

LibWeb: OOPWV View Source doesn't work with big documents #5519

Open Lubrsi opened 3 years ago

Lubrsi commented 3 years ago

For example, viewing the source of https://getbootstrap.com/docs/3.3/css/ crashes with:

WebContent(36): ClientConnection(0x023d0318)::post_message: Peer buffer overflowed

xeons commented 3 years ago

So If I'm reading things correctly, it looks as though the max buffer size is 1024 bytes. Looks like using an AnonymousBuffer might be the way to go when it comes to transferring large amounts of data. I'll look into fixing this.

Edit: The limitation must be somewhere else, I'll keep looking.

AtkinsSJ commented 11 months ago

Works fine in Browser currently. No crash in Ladybird/Qt but it just never loads the source display. (Other pages do work.)