SerenityOS / serenity

The Serenity Operating System 🐞
https://serenityos.org
BSD 2-Clause "Simplified" License
30.41k stars 3.18k forks source link

ConfigServer: File system watcher does not update internal config #9629

Open mustafaquraish opened 3 years ago

mustafaquraish commented 3 years ago

It seems that the old_value field in the file system watcher is never updated to be the new one even if we have a change. This means that:

I'm happy to attempt to fix this, but I'm not 100% sure how to go about this, any advice would be great!

Here's a demonstration video (Using #9639, with the fix from 317f55b applied): Video

mustafaquraish commented 3 years ago

Edit: Upon some further testing, it seems 317f55bb has not fixed the issue.