Incorrect relation calculated

[se-sss]

Sample.zip

Check KKKKKKK and MMMMMM

[se-sss]

curRel=rkSon prevRel=rkWifeFather prevprevRel=rkWife finRel=rkBrotherInLaw_W

[Serg-Norseman]

I found the problem, it is not in this algorithm at all and not even in GK. In 3-4 hours, as soon as possible, I will make commits.

The problem is in the EnumSet class from my BSLib library. Although the class is designed for ulong (64bit), mistakes were made in a couple of places and the maximum fit was 32bit. Because of this, and also because of recent improvements with the replenishment of types of relationships, some of them no longer fit in the container. I was lucky - I introduced two new rules to detail the current situation and was very surprised when I found that they did not work at all. Then it got easier...

[Serg-Norseman]

Have you checked? Does it work correctly in your case or is it still wrong?

[se-sss]

I have

[se-sss]

KKK - племянник F, А жека MMMM я бы ожидал

[se-sss]

Так выдаёт старая версия И это правильно

[Serg-Norseman]

But according to the definition, an aunt's husband is an uncle, even if not his own, so I did it

[Serg-Norseman]

I'm afraid that the difference in the perception of definitions will constantly create problems)))

[se-sss]

Probably. Never heard idea that husband of aunt is also my uncle.

[se-sss]

А на улице так половина прохожих - дяди

[Serg-Norseman]

Probably. Never heard idea that husband of aunt is also my uncle.

Wiki. And in my family, the husband of my own aunt was an uncle, and I was his nephew. At least in everyday communication.

[se-sss]

Вообще, по хорошему эта штука должна подлежать ещё и локализации. Я как-то раз пересекался с китайцем в универе. У них там, например, брат старший и брат младший - это принципиальная разница и разное слово.

[Serg-Norseman]

Постепенная работа в этом плане идет. Недавно, например, для локализации на исландский были разделены пресловутые дяди и тети: как мне сообщили, обобщенные слова в исландском есть конечно, но нативными являются раздельные термины брат/сестра матери/отца. Вчера вот ввел дядя/тетя как муж тетки/жена дяди. Если такие неродные термины плохо применимы, в локализации их можно детализировать. Вот племянник/племянница всё равно останутся как есть.