feat: upstream sync

[SergeWilfried]

Summary by CodeRabbit

• New Features

  • Enhanced PDF generation by switching connection methods to improve compatibility and reduce errors.
  • Updated webhook filtering to include only entries with a null team ID, refining data retrieval based on user needs.

• Improvements

  • Improved feature flag fetching with better error handling and default value support, ensuring more stable feature management across the application.

[vercel[bot]]

@dguyen is attempting to deploy a commit to the Serge Wilfried's projects Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai[bot]]

Walkthrough

## Walkthrough This update enhances the functionality and robustness of the system by refining the connection method in the PDF generation service, adding a specific filter condition for webhook retrieval, and improving error handling in the feature flag management. These changes aim to optimize performance and reliability across different modules of the software. ## Changes | File Path | Change Summary | |-------------------------------------------------|-----------------------------------------------------------------------------------------------------| | `.../htmltopdf/get-certificate-pdf.ts` | Switched connection method to CDP for better version decoupling in PDF generation. | | `.../webhooks/get-webhooks-by-user-id.ts` | Introduced a new filter to only include webhooks with a null `teamId`. | | `.../universal/get-feature-flag.ts` | Enhanced error handling and header management in feature flag fetching functions. | ## Poem > 🐇✨ > In the land of code, where the bits frolic and play, > A rabbit hopped through, refining the way. > With a twitch of its nose, and a flick of its ear, > Bugs scatter in fear, as improvements draw near. > Oh, celebrate the dance of the keys and the script, > For with each line refined, our software is equipped! > 🌟🐾

---

Recent Review Details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

Commits

Files that changed from the base of the PR and between 201a9694a983b70039c6c0d83330a4f7a6d904fb and 20edee7f1a2293344827f20deee372381aa25021.

Files ignored due to path filters (3)

* `package-lock.json` is excluded by `!**/package-lock.json`, `!**/*.json` * `package.json` is excluded by `!**/*.json` * `packages/lib/package.json` is excluded by `!**/*.json`

Files selected for processing (3)

* packages/lib/server-only/htmltopdf/get-certificate-pdf.ts (1 hunks) * packages/lib/server-only/webhooks/get-webhooks-by-user-id.ts (1 hunks) * packages/lib/universal/get-feature-flag.ts (6 hunks)

Additional comments not posted (7)

packages/lib/server-only/webhooks/get-webhooks-by-user-id.ts (1)

`7-7`: Ensure the new filter condition aligns with intended business logic. Please verify that the addition of `teamId: null` correctly implements the desired business logic and does not inadvertently exclude necessary data.

packages/lib/server-only/htmltopdf/get-certificate-pdf.ts (1)

`21-23`: Switch to Chrome DevTools Protocol (CDP) to reduce version coupling. The change to use `connectOverCDP` instead of `connect` is a good strategy to reduce dependency on specific Playwright versions. Please ensure thorough testing to confirm compatibility and stability of this new connection method.

packages/lib/universal/get-feature-flag.ts (5)

`20-20`: Removal of 'content-length' header to avoid pre-calculated length issues. Good practice to remove the 'content-length' header to prevent potential issues with pre-calculated content lengths. Ensure this change is reflected wherever request headers are manipulated. --- Line range hint `29-42`: Enhanced error handling in feature flag fetching. The addition of robust error handling by logging errors and returning default values ensures the system remains functional even when external services fail. This is a critical improvement for resilience. --- `55-55`: Consistent removal of 'content-length' header across feature flag functions. Consistent application of best practices across feature flag functions by removing the 'content-length' header. Ensure this change is reflected in all relevant parts of the codebase. --- `73-76`: Consistent error handling across feature flag functions. Maintaining consistency in error handling across different feature flag functions enhances system resilience and reliability. --- `98-101`: Robust error handling for anonymous feature flag fetching. Implementing robust error handling for anonymous feature flag fetching is crucial, especially since these users might not have other fallback mechanisms. This ensures a smoother user experience.

--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.