Closed DonMischo closed 2 years ago
Ok, easy enough to fix, these could simply be more "positional parameters" (i.e., fixed columns at the beginning of the CSV).
But let's focus on the MVP first.
Placeholders to implement:
#absenceDays
#absenceHours
#absenceDaysUnauthorized
#absenceHoursUnauthorized
Starting this now :mag:
Turns out, branch is already prepared, PR was created today: https://github.com/SergelsOrg/csv2tex/pull/71
Placeholders to implement:
#absenceDays
#absenceHours
#absenceDaysUnauthorized
#absenceHoursUnauthorized
You know what? This seems like the less ambiguous choice:
private static final String TEX_TEMPLATE_PLACEHOLDER_ABSENCE_DAYS_TOTAL = "#absenceDaysTotal";
private static final String TEX_TEMPLATE_PLACEHOLDER_ABSENCE_DAYS_UNAUTHORIZED = "#absenceDaysUnauthorized";
private static final String TEX_TEMPLATE_PLACEHOLDER_ABSENCE_HOURS_TOTAL = "#absenceHoursTotal";
private static final String TEX_TEMPLATE_PLACEHOLDER_ABSENCE_HOURS_UNAUTHORIZED = "#absenceHoursUnauthorized";
...
- [ ] Also, we should add a simple integration test that runs the (half year) template, and checks that this does not fail (DAU proofing for future local changes) - in generation of Latex code and replacement in template #60 we could not do it yet
A bit tricky, currently, because, for example, #48 is not done yet. For the smoke test, I first have to install the missing packages.
Also, statements like \input{SchoolReportTemplate_ZeugnisTemplate_Commands.tex}
need to be replaced with absolute paths, as we run the PDF transformation in a temporary directory, currently, to avoid side effects in the codebase, and because texi2pdf does not allow specifying an output file. But we can work around that
:arrow_up: Moving this task to a separate issue
The rest is fixed, yippie! :)
absence days and hours need to be added for base data
4 more columns are need for base data in csv:
absent days (Fehltage)
absent days unexcused (Fehltage ue)
absent hours (Fehlstunden)
absent hours unexcused (Fehlstunden ue)
[ ] Also, we should add a simple integration test that runs the (half year) template, and checks that this does not fail (DAU proofing for future local changes) - in https://github.com/SergelsOrg/csv2tex/pull/60 we could not do it yet