search

SergeyMell / nativescript-plugins

Apache License 2.0
14 stars 4 forks source link

Fixed ios compatibility (Buffer + deprecated imports) #14

Closed sebj54 closed 3 years ago

sebj54 commented 3 years ago

Hi :)

I was testing out your plugin with iOS and found deprecated imports (like on Android: https://github.com/SergeyMell/nativescript-plugins/issues/9). I replaced them by the correct ones.

I also found that Buffer is included with Node, but is not present in the app when it is executing. So I imported this plugin: https://www.npmjs.com/package/buffer.

It is working so far, I just have an issue with my SVGs not having the correct ratio. I'm actually trying to figure out why but I don't think it is related to this issue.

SergeyMell commented 3 years ago

It is working so far, I just have an issue with my SVGs not having the correct ratio. I'm actually trying to figure out why but I don't think it is related to this issue.

I always had to set width and height for images manually. Otherwise aspect ratio is not guaranteed.

sebj54 commented 3 years ago

I will try to fix dimensions like this so. Thanks!

sebj54 commented 3 years ago

Hi @SergeyMell, I just wanted to update my app with latest version of the SVG plugin but the latest version on npm is older than this PR. Is it planned to update the plugin on npm? If not, can I build the plugin locally from this repo?

Thanks for your help :)

EDIT: I just found out how to do and the plugin is not working for iOS actually. I'm preparing a new PR