search

SergeyPirogov / video-recorder-java

This library allows easily record video of your UI tests by just putting couple annotations.
http://automation-remarks.com/video-recorder-java/
MIT License
219 stars 66 forks source link

not update RemoteVideoListener.java for New RecordingMode.ALL #1

Closed crazyk2 closed 8 years ago

crazyk2 commented 8 years ago

you forgot to rewrite the class testng/src/main/java/com/automation/remarks/testng/RemoteVideoListener.java to work with new Mode (RecordingMode.ALL)

Change to private boolean videoEnabled(Video video) { return VideoRecorder.conf().getMode().equals(ALL) || (video != null && video.enabled()); }

SergeyPirogov commented 8 years ago

@crazyk2 ok, need to be fixed in 1.0.5 version

SergeyPirogov commented 8 years ago

Fixed by https://github.com/SergeyPirogov/VideoRecorder/commit/aac8f3835f9cd80d107ee07d49e5e32e5130c2ac

crazyk2 commented 8 years ago

please, give me your email, skype, whatsupp crazyk2@bk.ru i write fast fix for remote attach video and want to send it for you

SergeyPirogov commented 8 years ago

@crazyk2 why do not create pull request?

crazyk2 commented 8 years ago

@SergeyPirogov I want to consult and clarify some details

SergeyPirogov commented 8 years ago

@crazyk2 please add me sergio_894, because there are a lot skype ids similat to yours