Open GaspardCulis opened 2 months ago
I noticed the same thing. The install() method, therefore, always requires network access. Perhaps it would be worth adding another method alongside install(), such as get_cached_binary(), which would simply extract the latest driver from the cache? To achieve this, we only need to implement one method in DriverCacheManager, I can do it.
The
DriverCacheManager
initializes its_cache_key_driver_version
to None, and it never gets updated in the code. This means that even with aDriverCacheManager
you still have to fetch the remote driver version which can lead to API rate limit errors.To avoid running into these kinds of issues when having to run
GeckoDriverManager().install()
multiple times I'm currently using this dirty workaround:But it's not ideal. I guess the
DriverCacheManager
should assume that the desired driver version is the OS browser version (get_browser_version_from_os
)