Update your code

[Turcanuse]

Update code structure

• Read Ruby style guide. You can install rubocop gem for refactor code.
• Move Account class to account.rb file and Transactions class to transactions.rb file.
• Use CSS selectros instead of Xpath
• Take some time to navigate through the demo version, and find a way how to set dates in order to fetch transactions for past two months.
• Don't hardcode the number of accounts, the code should cover generic cases, for 5 accounts as in demo or 10 accounts.
• Use only lowercase characters for method parameters & variables, opt for snakecase
• Separate code logic in fetch and parsing methods and update code structure.
• Make your changes in dev branch and open a new pull request to master for review.

Example code structure:

class ExampleBank

  def execute
    connect
    fetch_accounts
    fetch_transactions
    save_result # in JSON file
  end

  def connect
    # here you log in to the bank
  end

  def fetch_accounts
    # fetch html data using nokogiri, take only fragment of html.
    html = Nokogiri::HTML.fragment(browser.div(class: "example").html)
    parse_accounts(html)
  end

  def fetch_transactions
    # go to transactions
    # set date for 2 month
    parse_transactions(account, html)
  end

  def parse_accounts(html)
    # parse accounts here
  end

  def parse_transactions(account, html)
    # parse transactions here
  end
end

Update data structure

• Save all JSON data in a file, I need to check result.
• Read again your test task, and check example.

{
  "accounts": [
    {
      "name": "account1",
      "currency": "MDL",
      "balance": 300.22,
      "nature": "account",
      "transactions": [
        {
            "date": "2015-01-15",
            "description": "bought food",
            "amount": -20.31,
            "currency": "MDL",
            "account_name": "account1"
        }
      ]
    }
  ]
}

date must be it json format example: "2020-08-20", balance and amount must be float not string.

Write tests

You should write a test that checks the data from demo bank.

1. Read about Rspec. It is a framework for test your code.

   • https://rspec.info
   • https://relishapp.com/rspec/rspec-expectations/docs/built-in-matchers

2. Write specs for parse_accounts and parse_transactions.

3. Take HTML from demo bank and save it in a file (check screenshot). html_example = Nokogiri::HTML(File.read('accounts.html'))

4. Call method for parse accounts and send HTML data. parse_accounts(html_example)

5. Check the number of accounts and show an example account in a hash format.

Example:

it 'check number of accounts and show an example account' do
  html_example = Nokogiri::HTML(File.read('accounts.html'))
  accounts = parse_accounts(html_example) # NOTE: It is my example, not a real code.

  expect(accounts.count).to eq(5)
  expect(accounts.first.to_hash).to eq(
    {
      "name"         => "Demo Everyday Account",
      "currency"     => "USD",
      "balance"      => 1959.90,
      "nature"       => "account",
      "transactions" => []
    }
  )
end

6. Do the same for transactions.

Good luck!

[Turcanuse]

A few more things to cover:

• Show example of account in hash format.
• Add spec for parse_transactions.
• move scroll_to_bottom to example file.
• Try omitting class variables

Good luck

[SergheiScepanovschi]

i don't have any global variables, I have only static fields in class(ok i can create object with dinamic fields, but i don't understend what is wrong). in test i tried to verify accouts data and transaction data in same time (ok i understood i have to separate them)

[SergheiScepanovschi]

I have updated files and created pull request for your comments.