search

Sergih28 / groc

Grind for the vision, revamp for precision, organize with decision, complete the mission.
MIT License
3 stars 0 forks source link

Fix main page issues #148

Closed Sergih28 closed 4 months ago

Sergih28 commented 5 months ago
  1. Fix failing types.
  2. Groc text in the navbar is not centered.
  3. If you make the page narrower, the pomodoro buttons end up on top of the navbar, that should never happen. This might be more of a structural problem of the whole website rather than the pomodoro component.
  4. When you click home button from another language other than the default, it goes to the default language home instead of keeping the same language.
    • It would also be nice here to add the feature to autodetect the language.
  5. The dark mode does not fully work. It always sets the dark mode at true when reloading the page. This tutorial might be handy.
  6. See if we can use maps for the objects we have in the store. This is not a fix but nice to have.
  7. The time does not count properly. Steps to reproduce with a fresh local storage:
    • Click start.
    • After 2 exact minutes, the pomodoro timer shows 24 13 instead of 23 00. This might be slightly different when you test it, but the point is that it's not counting the seconds correctly.
    • As for the tests, use the test id, and check why they are working first (the expect is not testing anything), but it seems like it does not go beyond 1 second anyway. So make them fail and then fix the issue.
  8. When you stop the pomodoro and refresh the page, it sometimes shows 1 less second. (Maybe it's best to save the milliseconds too?). UPDATE: Make it refresh every 0.1s instead of 1s, and adjust the last tick and pausing times to the tenth of a second.