Add react spring - Githubissues

Sergih28 / groc

Grind for the vision, revamp for precision, organize with decision, complete the mission.

MIT License

3 stars 0 forks source link

Add react spring #170

Closed ehdlg closed 3 months ago

ehdlg commented 4 months ago

What type of PR is this? (Check all applicable)

[x] 🚀 Feature
[x] 🐛 Bug Fix
[ ] 📚 Documentation
[ ] 💻 Blog post
[x] 🎨 Styles
[ ] 🛠️ Refactoring
[ ] 🕵️‍♀️ Code Review
[ ] 🚑 Hotfix
[x] 🧪 Test
[ ] 🌐 Localization/Internationalization
[ ] ⚙️ Configuration and Environment
[ ] 🚫 Deprecation or Removal
[ ] 📦 Release
[ ] ⏪ Revert

Description

Please describe the changes in this pull request:

Added animated counter numbers with react spring. Fixed counter tests after the counter animations were added.

Related Issues

Addresses #160

Checklist

Before submitting this pull request, please make sure you have done the following:

Code Quality

[x] Reviewed your code for any potential issues.
[x] Checked for coding style and formatting.

Updated documentation?

[ ] ✅ Yes
[x] 🙅 No, because there is nothing to update
[ ] 🙋‍♂️ No, I need help

Added tests for your changes?

[x] ✅ Yes
[ ] 🙅 No, because they are not needed
[ ] 🙋‍♂️ No, I need help

UI Changes

[ ] Added screenshots or recordings to demonstrate UI-related changes (if applicable).

Additional Information

Replace this text with any additional information.

Sergih28 commented 3 months ago

We should use tailwind's tabular-nums class so that all digits have the same width, otherwise the counter moves slightly depending on the numbers it's showing.