67 create the footer component in storybook - Githubissues

Sergih28 / groc

Grind for the vision, revamp for precision, organize with decision, complete the mission.

MIT License

3 stars 0 forks source link

67 create the footer component in storybook #92

Closed ehdlg closed 7 months ago

ehdlg commented 7 months ago

What type of PR is this? (Check all applicable)

[x] 🚀 Feature
[ ] 🐛 Bug Fix
[ ] 📚 Documentation
[ ] 💻 Blog post
[ ] 🎨 Styles
[ ] 🛠️ Refactoring
[ ] 🕵️‍♀️ Code Review
[ ] 🚑 Hotfix
[x] 🧪 Test
[ ] 🌐 Localization/Internationalization
[x] ⚙️ Configuration and Environment
[ ] 🚫 Deprecation or Removal
[ ] 📦 Release
[ ] ⏪ Revert

Description

Please describe the changes in this pull request:

Installed react-icons, a Footer component and its story

Related Issues

Please link related issues by removing lines that are not applicable.

Addresses #67

Checklist

Before submitting this pull request, please make sure you have done the following:

Code Quality

[x] Reviewed your code for any potential issues.
[x] Checked for coding style and formatting.

Updated documentation?

[ ] ✅ Yes
[x] 🙅 No, because there is nothing to update
[ ] 🙋‍♂️ No, I need help

Added tests for your changes?

[ ] ✅ Yes
[x] 🙅 No, because they are not needed
[ ] 🙋‍♂️ No, I need help

UI Changes

[ ] Added screenshots or recordings to demonstrate UI-related changes (if applicable).

Additional Information

Replace this text with any additional information.

Sergih28 commented 7 months ago

I think it's a bit overkill but a good practice, so please @ehdlg create the necessary tests for this component (with react testing library).