search

SergioBenitez / version_check

Rust library for checking the installed/running rustc's version.
https://docs.rs/version_check
Apache License 2.0
50 stars 14 forks source link

Document MSRV of this crate #8

Closed dekellum closed 5 years ago

dekellum commented 5 years ago

This project doesn't appear to have CI config (.travis.yml, etc.) as de facto standard minimum supported rust version (MSRV) expression. Do you know what the MSRV actually is for this crate? Could we document that?

The reason is that if someone (like me) wants to use version_check to enforce MSRV, and return a better error message, then we need to know what the MSRV of the version_check dependency is.

I can confirm it works as far back as rust 1.16.0. If you don't already know, then I guess I can binary search for the magic MSRV.

Also, would you be willing to consider CI to maintain that MSRV?

Thanks for releasing this!

dekellum commented 5 years ago

Had to minimize a test project for various other problems encountered along the way, but I am happy to report that version_check::is_min_version at least, compiles and works all the way back to rust 1.0.0, and I'm not interested in anything older! Would you consider a PR just to mention that in the README?

SergioBenitez commented 5 years ago

I'd happily accept such a PR, @dekellum!

dekellum commented 5 years ago

Thanks, LGTM!