SergiuToporjinschi / node-red-contrib-heater-controller

Heater controller for node-red dashboard
GNU General Public License v3.0
18 stars 17 forks source link

moving the slider triggers a swipe #37

Closed bgewehr closed 3 years ago

bgewehr commented 4 years ago

The slider for the target-temp does not stop the horizontal mouse movement events from propagating so the dashboard page changes when swipe pages is "on".

image

Could you add

event.stopPropagation(); probably?

SergiuToporjinschi commented 4 years ago

Hi @bgewehr , Thank you for letting me know about this. But unfortunately, angular is not calling my function with the event; So is not quite possible. This is quite ugly, but I have a good news. In next release I've added an option to have buttons and not a slider, should resolve this. Plus that in safarii resetting the custom value is not possible, and new new interface will allow you to push a button to reset it.

SergiuToporjinschi commented 4 years ago

Here is a preview ;) image

bgewehr commented 4 years ago

Cool! Personally I‘d prefer the details on the right but that’s just a personal taste.

Will you allow to edit the calendar via the widget? (It would be powerful to do that seperated and so to offer a generic weekdayplanner for all devices by just adding one to a group...)

SergiuToporjinschi commented 4 years ago

@bgewehr I would like to, but unfortunately I'm quite restricted by dashboard ui; I have other enhancement plan which I cannot finish due to this restriction; I wanted to have a button to open a dialog and display the logs (when the signal was send out from my node) and unfortunately I cannot open the dialog. Because in angular I need to have control of how the controller is define, but in Dashboard I don't have the standard angular definition so I cannot access the module.

bgewehr commented 4 years ago

What about a lightbox like https://noelboss.github.io/featherlight/

SergiuToporjinschi commented 4 years ago

@bgewehr hmmm I did worked with that but it could be useful. Thanks for the tip, I will take this in consideration