search

SergiuToporjinschi / node-red-contrib-heater-controller

Heater controller for node-red dashboard
GNU General Public License v3.0
18 stars 17 forks source link

After removing the sensor, the controller continues to operate. #42

Closed devifast closed 4 years ago

devifast commented 4 years ago

After posting issue # 41, my topic was closed after two comments by the author. That is, the controller continues to operate in the absence of a temperature sensor (the sensor is missing physically). This controller behavior causes events that are not good for each user. Imagine stretching a cable with a sensor through your home and your dog biting it, or has the sensor itself come in time? What happens if I rely on it for my tank or heat the water in a boiler? I do not mean to offend the author in any way, but this is unacceptable. This is a forum for discussion and problem solving. I am waiting for an answer. Greetings.

devifast commented 4 years ago

At the risk of offending the author, the temperature in big numbers should be the current one and set in the mac section.

SergiuToporjinschi commented 4 years ago

I cannot ensure the integrity of your network and your scenario cannot be detected by this node. I cannot suppose that a sensor is not working if the message is not coming; you have to take care of receiving the message; letting this as it is you are deciding how often you are sending the temperature to server. if you want to read it only once each year does not matter. This node will do one thing only. I want to have separation of concern. About the current temperature in big numbers, you can display it how ever you want without using this node. Nevertheless, you can, anytime fork this project and do the changes that you want.

devifast commented 4 years ago

Thanks for the reply, I'll try to resolve the issue in another way. Greetings.