search

SergiusTheBest / plog

Portable, simple and extensible C++ logging library
MIT License
2.19k stars 385 forks source link

Implementation of vasprintf emulation #243

Closed U-1F992 closed 1 year ago

U-1F992 commented 1 year ago

vasprintf for _WIN32 or non _GNU_SOURCE should be consolidated in this way.

vsnprintf here is a part of old C standards, so it will probably work in all environments that plog should support.

I've roughly confirmed that can build in the following environments, but more testing might be needed.

Related issues:

U-1F992 commented 1 year ago

It appears that the platformio-ci Docker image needs to be updated. I would appreciate it if you manage it.

SergiusTheBest commented 1 year ago

Thank you, @u1F992 !

It appears that the platformio-ci Docker image needs to be updated. I would appreciate it if you manage it.

Yes, let me take care of that.

SergiusTheBest commented 1 year ago

I made a new image with raspberrypi platform: it's ghcr.io/sergiusthebest/platformio-ci:latest.

U-1F992 commented 1 year ago

Thank you for the update! Now it has passed all checks.

SergiusTheBest commented 1 year ago

@u1F992 Thank you for your contribution!