Serhioromano / bootstrap-calendar

Full view calendar with year, month, week and day views based on templates with Twitter Bootstrap.
http://bootstrap-calendar.eivissapp.com/
MIT License
3.02k stars 1.29k forks source link

Upgrade to Bootstrap 5 #780

Closed tdtooke closed 2 years ago

tdtooke commented 3 years ago

You'll probably want to fix the twitter button. I did notice it didn't work as well in bootstrap 3 and it's even worse in bootstrap 5. Also the CSS needs looking at. I realigned the template files manually with style statements. I did notice it begin to drift in bootstrap 3. It was pronounced enough to need correction in bootstrap 5. Also on my personal site I did not need to have to tell it to make the event list 'block inline' so I probably missed something somewhere in modding the original files. Also there's no jumbotron in bootstrap 5 so I threw together something that would look like a jumbotron. You may want to do that differently.

Serhioromano commented 2 years ago

Fix twitter button? Look you have PR with 677 files changed. First of all most of them should be in .gitignore and never committed to Github. Second how I should check all those files? Another issue is that if I open .html templates or calendar.js I do not see what lines was changed. It replaces content of all files because general reformat or line ends, I do not know. But when you PR changed you should include only files that are essential for update and changed there should be trackable.

So, this PR in unmergeable.