Serhioromano / vscode-st

Extension for VS Code to support Structured Text language.
https://marketplace.visualstudio.com/items?itemName=Serhioromano.vscode-st#overview
MIT License
141 stars 28 forks source link

Msftrncs/1.3.1 #15

Closed Serhioromano closed 4 years ago

msftrncs commented 5 years ago

Cool! I was just going to PR this to you so you could evaluate it. I have been busy with PowerShell and haven't been as active on this, and that last item, 'support comma list of IMPLEMENTS' was defeating me.

I might still have something that is causing TYPE to bleed in to other objects in some conditions, probably something left over from earlier attempts at the list of IMPLEMENTS. As long as a POU contains a VAR block it seems fine.

Serhioromano commented 5 years ago

I'll have to decline this. I made this PR to see difference and what was changed. Unfortunately main syntax file become unmergable but only replacable. There is not changes tracking on it.

As I have already suggested please submit as separate PR every new rule. First create new branch, from development, make changed, submit PR, then again new branch from development, new changes, new PR.

I know that is more work but thus we can separate one change from the other and control it much better.