search

Serhioromano / vscode-st

Extension for VS Code to support Structured Text language.
https://marketplace.visualstudio.com/items?itemName=Serhioromano.vscode-st#overview
MIT License
141 stars 28 forks source link

Logical Operator Colouring #21

Closed kyle-goodwin closed 3 years ago

kyle-goodwin commented 3 years ago

In some themes, defaults included, the logical operators are not coloured.

To solve this I do one of the following:

The first solution is not correct because this is not a python extension. I'm not sure why python is the only one that gets called out for clouring in the theme.

The second one is more proper but only affects the 1 theme and isn't something the extension can solve on it's own.

Another ST extension uses support.class.collection.st which I don't think is correct either.

Pretty minor issue and I have no idea how to fix it properly but would be nice to get it highlighting in all themes.

Serhioromano commented 3 years ago

One of the solutions is to create theme and install it with extension so that theme may support even more colorings.

May be it is possible to contribute to dark_vs.json? I created on https://github.com/microsoft/vscode/pull/110847

Support it with a thumb up.

Serhioromano commented 3 years ago

My PR was rejected but they gave some suggestions. Read it.

kyle-goodwin commented 3 years ago

Bit of a lame reason for rejecting the request. It does seem like an oversight in that it is only implemented for Python. Oh well.