Serhioromano / vscode-st

Extension for VS Code to support Structured Text language.
https://marketplace.visualstudio.com/items?itemName=Serhioromano.vscode-st#overview
MIT License
142 stars 28 forks source link

Langium/dev - Structure text grammar without declarations #51

Open rempAut opened 1 year ago

rempAut commented 1 year ago

Still WIP - opening this PR to have a place for discussions.

Serhioromano commented 1 year ago
  1. Perhaps you are right not to include generated files. I'll delete those from Git and add .gitignore
  2. I have created pou.langium. This is going to be a file for entry to generate. I have there a base structure already.
  3. I have changed langium-configuration to make that pou.langium an entry point also I deleted generation of syntax file because our syntax file is good already. Every time you generate langium it replaces syntax and highlights are gone.
  4. I have added some validation rules to test how it will work.
rempAut commented 1 year ago

OK. My main task now is to tidy up the generated AST, so it is actually usable.

Serhioromano commented 1 year ago

NO worries. I've managed to pull custom symbol providers.

Serhioromano commented 1 year ago

I created custom symbol provider. It works fine! I like it. If you want, you can test it. Check out features/lsp branch, run npm run langium:generate and launch Run Extension.

I also ass Attach Server debugger to debus server side.

rempAut commented 1 year ago

Hey, I'm currently dealing with reference scoping issues. I'll be able to commit more during christmas - end of the year is always crazy in our company.

Serhioromano commented 1 year ago

Hey, I'm currently dealing with reference scoping issues. I'll be able to commit more during christmas - end of the year is always crazy in our company.

Thanks for letting me know. I understand that the end of the year can be a busy time for many companies. I'll look forward to your contributions once things have settled down.

Serhioromano commented 1 year ago

Hey, I'm currently dealing with reference scoping issues. I'll be able to commit more during christmas - end of the year is always crazy in our company.

By the way my last answer was what ChatGPT suggested me to answer on your comment :)