search

Serial-ATA / lofty-rs

Audio metadata library
Apache License 2.0
185 stars 34 forks source link

Make allocation limit configurable in `ParseOptions` #208

Closed Serial-ATA closed 10 months ago

Serial-ATA commented 1 year ago

Summary

The default allocation limit of 8MB could potentially not fit every use case, it would be nice to have this be configurable.

API design

impl ParseOptions {
    pub fn allocation_limit(&mut self, limit: usize) -> Self;
}
G2-Games commented 11 months ago

I have run into several files that are larger than this limit, is there a solution for now?

I can provide a file if needed

Serial-ATA commented 11 months ago

There's no way to work around the limit for now.

I am intrigued though, you have files with tags exceeding 8MB? Do you have a bunch of large images or is it something else?

G2-Games commented 11 months ago

Yes, I have a few files that I have encountered in my library that have ridiculously large images

Serial-ATA commented 11 months ago

Alright, I might be able to get this implemented next week.