search

Serial-ATA / lofty-rs

Audio metadata library
Apache License 2.0
187 stars 35 forks source link

mp4: Skip unexpected or empty "data" ilst atoms #261

Closed uklotzde closed 1 year ago

uklotzde commented 1 year ago

Make use of ParsingMode and ignore invalid/unexpected ilst atoms that could safely be ignored.

I found a few affected files that are accepted by other MP4 parsers.

PS: It would be cool to include this in a v0.16.1 release soon.

Serial-ATA commented 1 year ago

Thanks! I'm not surprised atoms other than data can appear. Bunch of weird unspecified features of MP4 files with everyone doing their own thing.

I'll get 0.16.1 out after looking into #260.

uklotzde commented 11 months ago

@Serial-ATA How about releasing v0.16.1 after various fixes have been merged?

Serial-ATA commented 11 months ago

I was going to release 0.16.1 after looking into that UTF-16 multi-value frame issue that was a part of #260. I just haven't been able to come up with a good solution yet.

uklotzde commented 11 months ago

I was going to release 0.16.1 after looking into that UTF-16 multi-value frame issue that was a part of #260. I just haven't been able to come up with a good solution yet.

How do you extract the sample test data from the files?

Creating a draft PR with a failing test could be a good starting point for anyone to pick this up.

Serial-ATA commented 11 months ago

I just use a hex editor to either create tags by hand or just strip them out of files.

It may be beneficial to make a simple binary to dump out all of the tags. That would save people from having to do that or email me their assets. Can't say when/if I'll get that done, though.