Improper use of PascalCase/UpperCamelCase in the ItemKey enum.

Serial-ATA / lofty-rs

Audio metadata library

Apache License 2.0

179 stars 34 forks source link

Improper use of PascalCase/UpperCamelCase in the ItemKey enum. #327

Closed Hellrespawn closed 6 months ago

Hellrespawn commented 6 months ago

Summary

PodcastURL has URL fully uppercase, where all other instances of the word use Url. Similarly, PodcastGlobalUniqueID has ID fully uppercase where all other instances use Id.

API design

No response

uklotzde commented 6 months ago

Just fix it and open a PR. I guess @Serial-ATA is happy to merge these fixes. We have already introduced breaking changes, see #329.

uklotzde commented 6 months ago

Related: #107.

Serial-ATA commented 6 months ago

Yeah, I have no problem changing the variants. I'm just not a place where I can make those changes right now. It'd have to wait a few days unless a PR is made between then.

uklotzde commented 6 months ago

Done: #332.