search

Serial-ATA / lofty-rs

Audio metadata library
Apache License 2.0
187 stars 35 forks source link

ItemKey: Distinguish between Bpm and IntegerBpm #335

Closed uklotzde closed 8 months ago

uklotzde commented 8 months ago

Fixes #334.

Serial-ATA commented 8 months ago

I believe "BPM" in Vorbis Comments and APE is also expected to be an integer value. At least that's how Picard uses it.

uklotzde commented 8 months ago

I believe "BPM" in Vorbis Comments and APE is also expected to be an integer value. At least that's how Picard uses it.

I am only aware of ID3v2 and MP4 which impose these restriction. MP4 by atom type and ID3v2 by standard definition.

uklotzde commented 8 months ago

Client still need to handle case that the integer field contains an arbitrary string, e.g. a decimal number.

Serial-ATA commented 8 months ago

Yeah, better to play it safe here.

This is marked draft, was there anything else planned for it?

uklotzde commented 8 months ago

Yeah, better to play it safe here.

This is marked draft, was there anything else planned for it?

I first wanted to publish this for discussion. If you agree we could merge it.

Serial-ATA commented 8 months ago

Yep, these changes are good. Thanks!