Serial-ATA / lofty-rs

Audio metadata library
Apache License 2.0
179 stars 34 forks source link

File causes `attempt to divide by zero` panic #342

Closed qarmin closed 3 months ago

qarmin commented 5 months ago

Reproducer

I tried this code:

lofty::probe::read_from(&mut file);

Summary

Panic

thread '<unnamed>' panicked at /home/rafal/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lofty-0.18.0/src/ogg/vorbis/properties.rs:141:38:
attempt to divide by zero
stack backtrace:
   0: rust_begin_unwind
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:645:5
   1: core::panicking::panic_fmt
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/panicking.rs:72:14
   2: core::panicking::panic
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/core/src/panicking.rs:127:5
   3: lofty::ogg::vorbis::properties::read_properties
             at /home/rafal/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lofty-0.18.0/src/ogg/vorbis/properties.rs:141:32
   4: lofty::ogg::vorbis::VorbisFile::read_from
             at /home/rafal/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lofty-0.18.0/src/ogg/vorbis/mod.rs:42:5
   5: <lofty::ogg::vorbis::VorbisFile as lofty::file::AudioFile>::read_from
             at /home/rafal/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lofty-0.18.0/src/ogg/vorbis/mod.rs:15:10
   6: lofty::probe::Probe<R>::read
             at /home/rafal/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lofty-0.18.0/src/probe.rs:614:25
   7: lofty::probe::read_from
             at /home/rafal/.cargo/registry/src/index.crates.io-6f17d22bba15001f/lofty-0.18.0/src/probe.rs:657:2
   8: czkawka_core::same_music::read_single_file_tag::{{closure}}
             at ./czkawka_core/src/same_music.rs:828:15
   9: std::panicking::try::do_call
             at /rustc/82e1608dfa6e0b5569232559e3d385fea5a93112/library/std/src/panicking.rs:552:40

Expected behavior

No response

Assets

File - null.ogg.zip