Serial-ATA / lofty-rs

Audio metadata library
Apache License 2.0
179 stars 34 forks source link

Artist and Title values not found for some files #356

Closed martpie closed 3 months ago

martpie commented 3 months ago

Reproducer

No response

Summary

First, thank you very much for lofty, this is a great library!

I have a few files that cannot be parsed by lofty-rs, I have compiled them in the Drive folder below: one has not title and the other has no artists. npm's music-metadata can correctly parse them, so I assume there's a missing edgecase in Lofty maybe?

https://drive.google.com/drive/folders/1V18mLDt4UwNCnEALi5nw2SiCZw2hbr7d?usp=sharing

Expected behavior

No response

Assets

No response

Serial-ATA commented 3 months ago
'01 No Line On The Horizon - no artist - should be u2.mp3'`
--- Tag Information ---
Title: No Line On The Horizon
Artist: None
Album: No Line On The Horizon
Genre: Rock
Album Artist: U2
--- Audio Properties ---
Bitrate (Audio): 320
Bitrate (Overall): 322
Sample Rate: 44100
Bit depth: 0
Channels: 2
Duration: 04:08

This file has no artist tag, it only has an album artist. Does music-metadata not distinguish between the two?

'True Love Waits - no title - should be True Love Waits.mp3'`
--- Tag Information ---
Title: None
Artist: Radiohead
Album: Divers
Genre: Alternative
Album Artist: None
--- Audio Properties ---
Bitrate (Audio): 64
Bitrate (Overall): 64
Sample Rate: 22050
Bit depth: 0
Channels: 2
Duration: 04:49

This file has a tiny tag with no title, it only has an artist, album, and genre:

image

martpie commented 3 months ago

This file has no artist tag, it only has an album artist. Does music-metadata not distinguish between the two?

Ah interesting! music-metadata fallbacks to album_<tag_name> then, I think it's fair to not implement this behavior in lofty.

Thank you!