Serilum / .issue-tracker

Tracks all issues for Serilum's Minecraft mods on CurseForge and Modrinth.
https://serilum.com/
157 stars 40 forks source link

Elytra Slot [mod] incompatibility with Your Items Are Safe [mod] #1886

Open Tw1ntend0 opened 1 year ago

Tw1ntend0 commented 1 year ago

Information

Minecraft version: 01.20.1 Modloader: Fabric Fabric loader version: 0.14.21 Environment: Both

First mod name: Elytra Slot (Fabric/Forge/Quilt) First mod version: 6.3.0

Second mod name: Your Items Are Safe Second mod version: 3.4

[Worth Mentioning] Third mod name: Trinkets (Fabric) Thrid mod version: 3.7.0

Description

When I die while I have the elytras slotted into its respective trinket slot, the elytra is NEITHER put on the armour stand nor in the chest. Instead, it just drops to the floor. And if it's the only item I have in my inventory, a chest and armour stand doesn't even spawn. It would be amazing to see trinket items dumped into the chest :)

Crash report

No crash.

James103 commented 1 year ago

Do you get similar behavior with other trinket slots e.g. those added by Cosmetic Armor (visual armor override slots) or Doodads?

Tw1ntend0 commented 1 year ago

So I just ran some tests and yes, it seems that those mods also simply cause the 'trinketed' armour pieces to drop to the floor while other equipment goes correctly into the chest or armour stand.

Additionally, it seems that this mod doesn't spawn an armour stand to hold your armour if you have no items in your inventory whatsoever. While of course it is rare for you to have NOTHING in your inventory, it would of course make more sense for this mod to still out your gear on an armour stand even if you have no chestable items—unless this is somehow a mod conflict on my end in which case ignore this feedback :)

filakhtov commented 2 months ago

This also has an unfortunate side-effect of elytra burning down in Lava, while the rest of the items being safe still. Would be awesome if Trinkets can be properly supported by Your Items Are Safe ❤️