Serilum / .issue-tracker

Tracks all issues for Serilum's Minecraft mods on CurseForge and Modrinth.
https://serilum.com/
153 stars 40 forks source link

Current Game Music Track just showing current biome #2100

Open Dannyxv8 opened 6 months ago

Dannyxv8 commented 6 months ago

Information

Minecraft version: 1.20.1 Modloader: Forge Forge version: 47.2.6 Environment: Singleplayer

Mod name: Current Game Music Track Mod version: 1.1

Description

Just wanted to say I really appreciate you creating a mod like this!! I've been wanting a mod like this for ages as I can never remember what the names are of my favorite tracks so thank you!

But as of now, the name popup is only currently showing the biome I'm in instead of the song's name when a song plays. I wasn't able to take a screenshot but "Danny" started playing and it just displayed "Cherry Grove".

SebSemos commented 1 week ago

I'm gonna up this... :p

It just show the "main categorie" of the sound.json list

    "music.end": {
        "replace": true,
        "sounds": [
            { anything played here will diplay "♪end♪" ingame

I have an idea to display custom songs tho. Assuming they are correctly defined throu the sound.json and not just replaced ogg files. From the wiki "subtitle" is an argument you can use, but also apply for the general music.something We could use it to set the track name the mod would display (having the ogg file would not be great as it can't have spaces or caps. Example:

"sounds": [
            {
                "name": "custom/pack_perso/game_music/end/lotr/amon_hen",
                "stream": true,
                "volume": 0.4,
                "weight": 15,
                "subtitle": "Amon Hen"
            },
.......
]