Serilum / .issue-tracker

Tracks all issues for Serilum's Minecraft mods on CurseForge and Modrinth.
https://serilum.com/
153 stars 40 forks source link

Overlapping areas with the same name still show enter/leave messages if the line breaks on their signs are not consistent #2364

Open kittymmeow opened 2 weeks ago

kittymmeow commented 2 weeks ago

Information

Minecraft version: 1.20.4 (also tested in 1.20.6) Modloader: NeoForge NeoForge version: 20.4.234 (used 20.6.62-beta for 1.20.6 test) Environment: Singleplayer

Mod name: Areas Mod version: 5.6 (used 5.8 for 1.20.6 test)

Description

Overlapping areas with the same name are not considered part of the same area (and therefore enter/leave messages are announced for same-name areas) if the presence of an extra line break in between [Area] and the area name is not consistent between the signs announcing the two overlapping areas. 2024-05-14_22 38 24

Tested to ensure that the issue was not caused by different types of signs (different wood or hanging vs wall signs) - issue goes away if the line break is consistent, regardless of sign type. It also doesn't matter generally whether the extra line break is present or not, the issue goes away as long as it is consistent for the entire same-name area.

It's possible this is what the user in #899 was encountering without realizing that this was why.

Also tested in 1.20.6 and the issue still occurs there so it wasn't incidentally fixed by anything else in newer versions.

Crash report

N/A no crash