Closed Viper67857 closed 2 years ago
I don't know what I'm doing, but I'm almost there lol
atm trying to figure out how I got it to display in the first place and then how I can adjust the size to fit in the space accordingly.
we'll see if I can do it, highly doubt it lol
You definitely got the right idea looking pretty good so far👏🏼
If I'm reading the code correctly, I can't modify it in an easy way, at least not if we want this to get this pushed to everyone.
All of the existing code is "linked" to show certain container.id's (the pages you see in the skin) and I don't think it would be advised to change that code just for it to work on this new section.
To display a poster in a specific size, I would have to create a new View_Library_Poster_Medium
and a new Object_MediumPoster
.
Yeah, so basically I can barely read this stuff let alone understand it. this is getting fun lol
atm I'm using diffuse/widgetposter.png
as it seems like the only thing that's close enough to the right size.
Just gotta move it around a little, then gut the code until everything else is gone and the new stuff remains. I really wish I knew what I was doing lol
Got it. Kinda. I know this IS NOT how it should be coded. but it looks fine'ish.
Let me know if this looks good to you and I'll get a branch made.
Looks great 👍
Fix4-Includes_View_Posters This should add Season Art to Episode Viewlist(Netflix Homestyle)
@SerpentDrago & @inb4after let me know how ugly this is lol
@jojobrogess Beautiful, thank you
@jojobrogess I have this problem
@jojobrogess I have this problem
You have to go into Kodi settings ,Media Settings,, General and disable Show parent folder items that should fix your issue🤞🏼
@xyzfre is correct, changing that setting should remove the parent folder icon that's displaying.
BUT it looks like from the photo you posted, I wrote the code wrong. I didn't think about widget aspect in respect to widget image profile.(or maybe it's carrying over something, honestly idk what I'm doing, I'm winging it over here lol)
In your photo you can see the "background" imageblur effect for season poster being displayed, when the episode image is in landscape.
I'll try to take a look at this tonight
@lebigboss where are you looking from?
I can't get my auramod to display episode art as season art in episode view mode Episode List
.
It looks like you're looking in a list within a list inside an addon(TMDBHelper,Seren.EmbuaryInfo,...) Walk me through how you got to that page, and maybe I can figure out why it's displaying like that.
I am also curious as to what List
and Info List
look like for episode View Mode
.
Is it displaying the seasonal art or episode art?
@jojobrogess It's the episode art, in Auramod you just need to uncheck this setting
And I think the problem is from the addon, I disabled Show parent folder but nothing change
It's a french addon for movies and tv show like Seren. Thx for your help
What is it called? Do you have the URL/GitHub?
I'll take a look at it and see what's going on.
@jojobrogess no they don't have github https://cdn.discordapp.com/attachments/928939486220525589/944904563809484822/plugin.video.sendtokodiU2P-0.5.20.6.zip
I went through the files and it looks like it does have a GitHub, but I can't tell if the version you sent me was modified from the GitHub version. I'm on my cell reading through the files.
https://github.com/firsttris/plugin.video.sendtokodi
I'll double check everything and post an update later on tonight if I find anything substantial.
Thanks for the quick reply!
The setting @xyzfre and I mentioned, was because of the picture you posted:
THAT Top Folder Icon, if you select it, will take you to the parent folder. The setting we were talking about, removes it.
SendToKodi plugin receives URLs and resolves almost all of them with yt-dlp creating a playable video stream for kodi.
AS for your plugin. That's was interesting. As well half in french, like code wise, and I don't speak french lol
It looks like your plugin is a modification of plugin.video.sendtokodi, it might be modifying it on the fly or using it as a resource, I'm not certain why it needs .pyc
files. Regardless...
I can see that in service.py on line 1789
:
def prepareUpNext(title, numId, saison, episode): notice(episode) sql = "SELECT link FROM tvshowEpisodes \ WHERE numId={} AND saison='Saison {}' AND episode=='S{}E{}'".format(numId, str(saison).zfill(2), str(saison).zfill(2), str(int(episode) + 1).zfill(2)) link = extractMedias(sql=sql, unique=1) notice(link) next_info = {} if link: try: mdb = TMDB(keyTMDB) tabEpisodes = mdb.saison(numId, saison)
['Épisode 1', 'Maud Bachelet semble vivre une vie parfaite ', '2022-01-10', '/jkV6JVxXIiDujhEyFreyEo5IxUe.jpg', 0.0, 1, 1]
if [x for x in tabEpisodes if x[-1] > int(episode)]: next_info["current_episode"] = [dict([ ("episodeid", x[-1]), ("tvshowid", 0), ("title", x[0]), ("art", { 'thumb': "http://image.tmdb.org/t/p/w500%s" %x[3], 'tvshow.clearart': "", 'tvshow.clearlogo': "", 'tvshow.fanart': "", 'tvshow.landscape': "http://image.tmdb.org/t/p/w500%s" %x[3], 'tvshow.poster': '', }), ("season", x[-2]), ("episode", x[-1]), ("showtitle", title), ("plot", x[1]), ("rating", x[-3]), ("firstaired", x[2])]) for x in tabEpisodes if x[-1] == int(episode)][0] next_info["next_episode"] = [dict([ ("episodeid", x[-1]), ("tvshowid", 0), ("title", x[0]), ("art", { 'thumb': "http://image.tmdb.org/t/p/w500%s" %x[3], 'tvshow.clearart': "", 'tvshow.clearlogo': "", 'tvshow.fanart': "", 'tvshow.landscape': "http://image.tmdb.org/t/p/w500%s" %x[3], 'tvshow.poster': '', }), ("season", x[-2]), ("episode", x[-1]), ("showtitle", title), ("plot", x[1]), ("rating", x[-3]), ("firstaired", x[2])]) for x in tabEpisodes if x[-1] == int(episode) + 1][0]
There is no definition for season art. Or only looks up landscape art?
I don't have the 3 services it requires to run the addon, so I can't mess around with the code and see what happens lol Maybe you can try to notify the devs? And they can add in the code. It's hard to fix something I can't even run. Sorry I wasn't much of help
But as far as I know, the episode modification should work through other addons/plugins as long as they can supply season art or default to poster image style rather than landscape.
HEY @lebigboss , it looks like TheMovieDBHelper just issued an update that might cover your addon displaying landscape art as season art.
It looks like the top half of the convo was about french art through tmdbh's new language/art update, and some bugs. (Bottom half is about aura homestyle landscape panel clearlogo always appearing regardless of skin settings)
The comment that caught my eye:
Originally posted by @matke-84 in https://github.com/jurialmunkey/plugin.video.themoviedb.helper/issues/654#issuecomment-1047281704
I would change only one thing. For season specific lendsacape I would leave fanart.tv when is turned on prefer artworks from tmdb. TMDb landscape images are actually language backdrops. Tmdb doesn't have landscape images for the seasons but since we set as fallback those images then display them now.
blacklist landscape tmdb_art for seasons #654 <--commit https://github.com/jurialmunkey/plugin.video.themoviedb.helper/issues/654 <--issue
It might cover your use case, if you have your settings like that. And since I can't test out if it did fix it, I thought I'd mention it. If it does fix it, let me know. Because that would be awesome lol
Fix4-Includes_View_Posters This should add Season Art to Episode Viewlist(Netflix Homestyle)
@SerpentDrago & @inb4after let me know how ugly this is lol
FYI, in testing this, I noticed there was a smaller poster outline showing inside the poster:
I commented out lines 311-313 in Includes_View.xml to get rid of it
` <!--
</control> -->`
After edit:
@meesterexx THANK YOU!!!
new update with fixed code here:
https://github.com/jojobrogess/skin.auramod/tree/Fix4-Includes_View_Posters
FROM:
50 view_pad 420 Container.Control.IsVisible(502) | Control.HasFocus(502) widget_poster_width widget_poster_height common/box.png Control.IsVisible(58) -10 -10 Control.IsVisible(58) View_WatchedOverlay common/outline.png -10 -10 -10 -10 Control.HasFocus(58) View_Selectbox
TO:
50 view_pad 420 Container.Control.IsVisible(502) | Control.HasFocus(502) 350 550 common/box.png Control.IsVisible(502)
PLEASE let me know if I added more bugs lol
@inb4after is there any way this feature request can get merged in, as well? I haven't seen any bugs from this change and no one has reported anything since I posted this.
It also seems to be a great addition for that view type.
https://github.com/jojobrogess/skin.auramod/tree/Fix4-Includes_View_Posters
I can create an updated PR for this too, just let me know
I think I got something wrong somewhere, and I don't know how I didn't notice it before (maybe it's because I'm using Nexus atm and it wasn't loading in before)
But if you have a semi played file it will show the episode thumb
(unless you have Use TV Show fanart for Episodes
selected in skin settings) in the season art spot breaking some logic:
The shader box's size needs to be set conditionally based on the output.
ie: that size when season art is being displayed, and another when UseTVShowfanartforEpisodes
is not enabled for in progress TV Shows.
I'll see if I can do this.
ALSO FYI If you downloaded this from my branch and want more of the fixes that have come out since I originally posted it, just re-download it from the same branch (! others have different fixes and some are broken).
I have merged and updated the branch to keep it current with this one. And will continue to do so until/if the feature is added in.
There's currently a large area of dead space below the current season label, which would be a perfect place for the season poster. Here's a hack job preview I did on my phone: https://imgur.com/a/UJi4Rfq