SerpentDrago / skin.auramod

Auramod Skin for Kodi 18
85 stars 20 forks source link

Main Menu Selection Focus Buggy on Exit #271

Open XxAcielxX opened 2 years ago

XxAcielxX commented 2 years ago

Hello,

I'm facing this issue ever since I started using AuraMOD Skin (like 6-10 months). From the Home Screen when I enter any Main Menu Entry and exit it, the selecting focus automatically moves to the Submenu Categories.

  1. Selection is on Add-ons screenshot00000
  2. Entered the Add-ons screenshot00001
  3. Exited Add-ons and as you see the Selection has automatically moved to first Submenu Category Video add-ons screenshot00002

LibreELEC 10.0.2 (Kodi 19.4) AuraMOD 1.1.9 Home Style: Aura Home Style Menu Style: Horizontal Style

This is happening since fresh install and have not been fixed in the last 2-3 updates of the skin.

jojobrogess commented 1 year ago

I remember noticing this a while back myself.


Pressing back, or selecting the previous screen, should reflect the initial selection and not just reload the previous window. Trying to fix that might be tricky when returning to a field that doesn't exist(anymore), or when a refresh has happened and the container holding that content has changed.

I thought this issue was about navigation back to the home screen being buggy, I missed this part:

the selecting focus automatically moves to the Submenu Categories.

sry

jojobrogess commented 1 year ago

Yeah I think I get what happened here:

Somewhere along the lines you selected the option Open Category Widget on Focus while using the Menu Layout Vertical Icon w/ Labels. Sadly it looks like that code option is only available while in that Menu Layout, so if you switch you never see that option to be able to turn it off again.

Switching back to that Menu Layout should give you the ability to turn it off. Settings>Skin Settings>Home> Choose Menu Layout change to Enable Vertical Icon w/ Labels Deselect the option - Open Category Widget on Focus


Although you did say:

This is happening since fresh install and have not been fixed in the last 2-3 updates of the skin.

I assume you don't mean a literal fresh install, one with no saved skin settings. And you just mean a fresh AuraMod install, which would have some saved settings. Unless you got rid of your old userdata folder with all your old setting in it, this setting would still be saved in Kodi\userdata\addon_data\skin.auramod\settings.xml.

IF YOU DID DELETE THAT FOLDER, and start from a literal fresh install, then yeah this is a bug of some sort.


The easiest way to fix this would be to just remove the visible condition from the setting. That way, when you're in other Menu Layouts, you can see that you have that setting selected.

https://github.com/SerpentDrago/skin.auramod/blob/4e6fdc00121ce139ee1c95a38858394b13a0e7f4/1080i/SkinSettings.xml#L309

2023-02-18 01_36_02-Kodi

The logic will still be there for it to only be able to be used if in the Menu Layout Vertical Icon w/ Labels.

Sadly there is no notification that says that though.. (although, I was thinking about adding an information tab, like you see in the bottom left of other settings windows. So users can get a little more info on what the settings actually do. But that's hours of work and idk how to add it or what every setting even does, yet)


I posted a fix here: https://github.com/jojobrogess/skin.auramod/tree/Fix4-OpenCatWidgetonFocus

(The only other updates in that branch are GITHUB updates meant for that repo to work correctly.) https://github.com/jojobrogess/skin.auramod/commits/Fix4-OpenCatWidgetonFocus

Let me know if this works for you!

XxAcielxX commented 1 year ago

Deselect the option - Open Category Widget on Focus

I already have this unticked.

I assume you don't mean a literal fresh install, one with no saved skin settings. And you just mean a fresh AuraMod install, which would have some saved settings. Unless you got rid of your old userdata folder with all your old setting in it, this setting would still be saved in Kodi\userdata\addon_data\skin.auramod\settings.xml.

By fresh install I meant completely new install of LibreELEC OS and the AuraMOD Skin after doing a format. So no old settings or files were there.

https://github.com/jojobrogess/skin.auramod/commits/Fix4-OpenCatWidgetonFocus

Tried this fix by deleting line 309, and it still doesn't fix the issue sadly.

I'm using the Aura Home Layout with Horizontal Top. Isn't the above fix work with Netflix Home Layout only?