SerpentDrago / skin.auramod

Auramod Skin for Kodi 18
83 stars 20 forks source link

Kodi Nexus 20 #276

Open JFG1000 opened 1 year ago

JFG1000 commented 1 year ago

Are there any plans to have this skin fully compatible with nexus?

inb4after commented 1 year ago

I was working on a large update a few months ago which fixes a lot of bugs and has some visual improvements.

Unfortunately, because of lack of free time I haven't been able to finish this to the point where it is ready to release. This release would target Kodi 19.

Because of this, I don't see a Kodi 20 compatible release anytime soon, but it will eventually come after this next AuraMOD update.

For now, you can still use AuraMOD on any Kodi 19 versions.

JFG1000 commented 1 year ago

That's totally understandable we all have lives, having auramod compatible with nexus as a confirmation from yourself is something I'm really looking forward to though so thankyou

jojobrogess commented 1 year ago

I have v20.0-ALPHA3 running atm. I got a new laptop and can't seem to run v19 anymore without weird graphics problems. (4k screen) I get the same amount of bugs as I did from my old laptop when it was on v19, at least from the netflix side of things. (I haven't really been poking around though)

Everything mostly works already, there are little bugs here and there but I haven't had anything completely break. I am dealing with some weird TV episode stuff, where some episodes aren't showing up in a series but I don't think that has to do with the skin. I saw something saying that they updated the logic of how scraping works(or nfo's? idk), and that it messes with older libaries so you have to rescan and clean up outdated nfo data.

Anyways, I finally got some free time from work for a while so I was thinking about spending some time looking into some of these bugs since I've been mia for a while.

I just I fixed the long standing bug with transparent/horizon movie genre icons not showing up correctly, at least on the genre widget style. I haven't been able to figure out why the icons don't show up on other widget styles. But I'll get there lol I'm pretty sure it's just missing the logic for using the genre icons as a source.

If I'm able to fix anything else, I'll post a PR. I do also have a couple fixes/features that were never PR'ed in from months ago: Added episode poster art to Episode List view mode, AuraMod style UpNext Window Normal and Minimal(removed obsolete NextUp code), and a couple other realistically non-critical fixes.

I'll try to get a clean copy of github up and running so I can get everything aggregated, some of the fixes might still be on my other laptop.

JFG1000 commented 1 year ago

You absolute legend, i would love auramod to run smoothly on nexus but the most irritating bug I've come across so far is the crashing, alot of the time when i use the showcase view it quite often crashes, this is from the main home screen, then i click the see more widget, it then brings up the showcase view and after navigating it quite often crashes

jojobrogess commented 1 year ago

Current Bug List

I was able to fix #22 Up Next addon not work, like I said previously I had to remove the old NextUp code and update the code for AuraMod style UpNext Windows' Normal and Minimal.

I was also able to fix #230 Add Music/Movies/TVShows Genre icons, which has been a long standing bug not allowing you to use horizon genre icons(at least for me). I AM unaware, at least at this moment, if I was able to fix this for music.

I have started working on #164 [Redesign] MPAA Rating display, and I'm almost done.

261 Widget Genre Missing Icons, is completely kicking my butt.

Why am I having a hard time with this? Well the widget style is called submenu to users but in the code its called widget category and then the variable name is logo. All those words are used with other things all throughout the code. And idk what I'm doing so I'm completely lost.

If I was able to figure out where and how all that works, I'm pretty sure I could figure out:

23 Small widget bar labels disappear when disabling "enable categories label on widget bar", and then

249 Movie Widgets are broken!, should be easier to fix.


After all those, then pretty much all bugs pertaining to widgets on the home screen should be fixed.

From there we have all the bugs within lists and pages, like:

232 TMDBHelper Next Page inside Cast & More Error,

267 [Bug] Clicking on a movie/show inside cast&more displays the home screen before going to that selected movie/show,

268 [BUG] TMDBHelper crashes when trying to open context menu on a movie inside Cast&More, but only in a very specific circumstance. Possible Memory Leak. Bug caused by Auramod Widget,

I'm pretty sure all of those should be fixed by inb4afters' work.


These issues need to be fixed:

214 Does auramod support artist bio??, I think is a longstanding Kodi/Aura bug mixed together. I don't know where to start.

223 [Bug] In Search Catagory, Option -Use default keyboard is enabling itself., looks like DolphinLaser was able to figure out a quick fix which might help me with figuring out a real fix.

225 [Bug] Option "Disable Settings Background" is not showing the background image on other settings., doesn't look too hard to fix, at first glance lol

237 Is this something that could be added to AuraMod, work has been done and jurialmunkey has implemented a workaround.

245 Error in the self-closing of the OSD information screen when playing on tvbox, I don't know where to start.

250 Skin Backup/Restore does not seem to do anything, I don't know where to start.

252 Widgets created from Lists do not work, which is well way beyond me, at this point. But apparently is causing huge issues for people. And is probably the most broken/highest priority issue.

269 The Auramod search doesn't return any results for Arabic words., I don't know where to start.

271 Main Menu Selection Focus Buggy on Exit, I don't know where to start.


These issue APPEAR to be fixed:

92 Cast & More > Cast, and #204 No Cast, Similare..etc.. when netflix view is disabled for TVShow!!, appear to be the same issue.


Error/Outside The Scope/Probably will never fix:

113 Issue with items in widgets, looks to be a library/addon migration issue

146 Add trailer to Tv series, looks to be a user/addon error.

197 TV show and Movie menu not appearing, looks to be a user error/migration issue.

215 Could not connect to repository and #216 Is the zip number still 1.0?, look to be an error outside the scope of the skin.

222 Skin crashes Kodi on startup on Apple TV 4k, code needs to be fixed by someone who owns an apple 4k tv.

235 Failed to install dependencies, look to be an error outside the scope of the skin.

259 Ratings issue using Seren for episodes, look to be an error outside the scope of the skin.


Finale:

After all of those are Fixed and Cleared out; Then it would be onto features, which there are a lot of, if it's even possible at that point.

Then more than likely v20 will be out officially, and hopefully nothing breaks...


Let me know if I missed anything, I honestly feel like I left some out.

OH and PS: I'm going to be building a wiki to show how to setup every aspect of the skin from start to finish Then show all the settings with images and descriptions.

(More than likely while doing this, I will update the files found in the skin files/textures. Just to update everything)

Here's a link: AuraMod Wiki It's super under construction at the moment, just has the original stuff and templates for the future stuff.

jojobrogess commented 1 year ago

@JFG1000

the most irritating bug I've come across so far is the crashing, alot of the time when i use the showcase view it quite often crashes, this is from the main home screen, then i click the see more widget, it then brings up the showcase view and after navigating it quite often crashes

Can you open a new issue for this? Try to add a photo/video or log so we can see what's going on, hopefully it's not intermittent so it's not hard to catch.

JFG1000 commented 1 year ago

Yes I can try tomorrow unless you could test your end as I've had to restore my build several times recently and don't get lot of time at the moment, if you install an addon like fen etc click on something to open up the showcase view and it's pretty easy to trigger, can even give you my build to test if you reach out to me privately I'll send you the details?

Nuklear92 commented 1 year ago

There's another issue/bug with AuraMod that I've been noticing since a long time. Which is that regardless of having FanArt Key ON within TMDB Helper and other addons. There's no Fallback FanART Artwork within Episodes, Seasons, etc. Specially when there's new episodes within the UpNext, or going directly into the Season from the show itself. If the Episode/s hasn't been updated officially from TMDb with their official artwork instead of showing the FanArt artwork which it shows in skins like Arctic Horizon 1-2, etc. It just fallback to the TV Show's Background Landscape Artwork. Instead of the Fanart Artwork when you enter your own fanart key and start using the service for fallback artwork when TMDb doesn't have or haven't updated yet that particular tv show, movie, etc.

Hopefully, you get what I'm talking about, or else I might have to try installing the skin in Nexus which isn't quite stable as of yet. ๐Ÿคทโ€โ™‚๏ธ

jojobrogess commented 1 year ago

@Nuklear92

There's another issue/bug with AuraMod that I've been noticing since a long time. Which is that regardless of having FanArt Key ON within TMDB Helper and other addons. There's no Fallback FanART Artwork within Episodes, Seasons, etc. Specially when there's new episodes within the UpNext, or going directly into the Season from the show itself. If the Episode/s hasn't been updated officially from TMDb with their official artwork instead of showing the FanArt artwork which it shows in skins like Arctic Horizon 1-2, etc. It just fallback to the TV Show's Background Landscape Artwork. Instead of the Fanart Artwork when you enter your own fanart key and start using the service for fallback artwork when TMDb doesn't have or haven't updated yet that particular tv show, movie, etc.

Hmm, could you open an issue for this? Try to add a photo/video so we can see what you mean exactly, this seems a little tricky(at least to me).

Thanks for your input as well! Calling anything weird out helps us all have a better experience in the end.

Nuklear92 commented 1 year ago

Sure, I'll try opening an issue about it. ๐Ÿ‘

JFG1000 commented 1 year ago

@JFG1000

the most irritating bug I've come across so far is the crashing, alot of the time when i use the showcase view it quite often crashes, this is from the main home screen, then i click the see more widget, it then brings up the showcase view and after navigating it quite often crashes

Can you open a new issue for this? Try to add a photo/video or log so we can see what's going on, hopefully it's not intermittent so it's not hard to catch.

Could you please tell me how i can create a log etc and I'll get on the case tomorrow for you

jojobrogess commented 1 year ago

AFAIK I think this skin sets the log level to 1, but you can get more information about how to turn on logging here.

Essentially you can create/add this code to your advancedsettings.xml file:

<advancedsettings>
    <loglevel>2</loglevel>  
</advancedsettings>

Which is located here:

Operating system Userdata Folder
Android Android/data/org.xbmc.kodi/files/.kodi/userdata/ (see note)
iOS /private/var/mobile/Library/Preferences/Kodi/userdata/
LibreELEC /storage/.kodi/userdata/
Linux ~/.kodi/userdata/
Mac /Users//Library/Application Support/Kodi/userdata/
Nvidia Shield (SMB) smb:///internal/Android/data/org.xbmc.kodi/files/.kodi/userdata
OSMC /home/osmc/.kodi/userdata/
tvOS /private/var/mobile/Library/Preferences/Kodi/userdata/
Windows %APPDATA%\Kodi\userdata
Windows Portable \portable_data\userdata\
Windows via Microsoft Store %LOCALAPPDATA%\Packages\XBMCFoundation.Kodi_4n2hpmxwrvr6p\LocalCache\Roaming\Kodi\
Windows Xbox %LOCALAPPDATA%\Packages\XBMCFoundation.Kodi_4n2hpmxwrvr6p\LocalCache\Roaming\Kodi\

Well I feel like it depends on what type of "Kodi" you're using, the normal one or a standalone like libreelec.

Depending on your device, logs are located in:

Operating System | File/Folder Path -- | -- Android | The folder may differ depending on the device: /data/org.xbmc.kodi/cache/temp/kodi.log /sdcard/Android/data/org.xbmc.kodi/files/.kodi/temp/kodi.log /storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/temp/kodi.log CoreELEC | /storage/.kodi/temp/kodi.log iOS/tvOS | /private/var/mobile/Library/Preferences/kodi.log LibreElec | /storage/.kodi/temp/kodi.log Linux | $HOME/.kodi/temp/kodi.log macOS | /Users//Library/Logs/kodi.log Nvidia Shield (SMB) | smb:///internal/Android/data/org.xbmc.kodi/files/.kodi/temp/kodi.log OSMC | /home/osmc/.kodi/temp/kodi.log Windows | %APPDATA%\Kodi\kodi.log Windows Portable | \portable_data\ Windows (UWP) | %LOCALAPPDATA%\Packages\XBMCFoundation.Kodi_4n2hpmxwrvr6p\LocalCache\Roaming\Kodi\kodi.log Special protocol | special://logpath (this can be used by scripts)


Operating System File/Folder Path Android The folder may differ depending on the device: /data/org.xbmc.kodi/cache/temp/kodi.log /sdcard/Android/data/org.xbmc.kodi/files/.kodi/temp/kodi.log /storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/temp/kodi.log ************************************************************************************************************************************** From there you can either upload the file directly to Github or through an online service like: https://pastebin.com/ And then there are internal addons like: https://kodi.wiki/view/Add-on:Kodi_Logfile_Uploader ![ovmfa47](https://user-images.githubusercontent.com/17692472/211703706-6b598a86-bcc3-45c8-a08f-151c01ef52b1.jpeg) I feel like these are little dumb because I absolutely HATE writing out URL's fully, but your feelings may differ. Sorry for the huge write-up, but I'm building up a wiki so I thought I'd just spend some time doing a part of it.
jojobrogess commented 1 year ago

ahhh shiit: Updated to v20 rc2 and now I'm experiencing some weird problems...

https://user-images.githubusercontent.com/17692472/212220794-97e58494-cf27-42a1-99d6-66a092d2b5b2.mp4

That's my video sources folder, pointed directly at my external E:/ drive. As you can see the list was long, but the second I backed out and went back in pretty much everything disappeared. As well at the end of the video, I go into the drive itself and show that it's filled.

Yep, so v20 isn't looking promising atm.

Alpha 3 was working fine for me, rc2 naaught so much. lol I'll have to reinstall. Hopefully this doesn't bug out my userdata folder

I suggest avoiding v20 At least until more of us brave into the deep and burn our builds.

Thankfully what I'm experiencing looks to be a Kodi problem rather than a skin one.

JFG1000 commented 1 year ago

I'm not sure if it's a Kodi one, i think it may be a skin one Also I'm reading AH2 is working on Nexus after some updates so I'm not sure if Auramod needs the same ones to keep it running, really don't want to have to switch to a skin but it now maybe time ๐Ÿคท๐Ÿผโ€โ™‚๏ธ

jojobrogess commented 1 year ago

That was a kodi v20 rc1+ library problem, or anything after it. I figured out I had to redo my TV Show nfo/directory structure.

But since I had multiple versions of Kodi installed at the same time switching between multiple builds, it got a little more buggy than usual. lol

The problem was I scanned my library, 4tb of real files, incorrectly in the first place. It just worked because Kodi hadn't depreciated that method yet, sadly V20 did.

Secondly, some addons would update to a nexus version which would break in a v19 version. And vice versa.

So the problem was really me. lol

You can see here on Kodi's website:

Addons

  • A BREAKING API change was introduced for the VideoStreamDetail and InfoTagVideo Python APIs. This affects set APIs that were introduced in the v20 development cycle. We would not normally do such a change when we enter Beta phase, but we believe fixing this now would cause fewer issues for all the addon devs out there for v21 (supporting 2 different APIs for v20/v21). Details around what is affected can be seen in the PR. In addition, further details can be seen and discussed on the forums.
  • A number of bundled addons have been updated. This should reduce the number of addons that immediately do updates on installation of RC1.

Scrapers

  • Due to the above breaking API change, the TVDB TV Show scraper was updated to prevent breaking. The result is that the updated scraper will be broken on any Kodi v20 release prior to this RC1 release. If you are using an older v20 install, then you need to update for continued functioning of the TMDB TV Show scraper.
  • In addition, we took this opportunity to fix a long outstanding issue with the Python TV Show scrapers described here. The result is that if you are adding new episodes to existing TV shows in your library, you need to refresh the show to download the new episode guide. If you are using NFO files, the episode guide in those files needs updating also.
  • TMDB TV Shows and TV Maze scrapers have been updated, with TVDB v4 to be updated in the near future. More details can be found here.

I am currently running AuraMod within Nexus without any noticeable changes/bugs whatsoever.

Everything works, well at least as well as it did in v19. HDR is WAYYY better for me, as well as 4k resolution(*W3840xH1984) There really aren't that many changes from v19-20 overall, and I don't think there are many skin deprecations.

It's just that all the stuff that was put on notice to become deprecated in v19 is now depreciated in v20. I haven't seen, or caught anything in the logs for the skin.

Which was just technically released:

Kodi v20

https://kodi.tv/article/kodi-20-0-nexus-release/

https://kodi.tv/download

JFG1000 commented 1 year ago

UPDATE : Using mavens kodinerds nexus apk, auramod runs flawlessly with no crashes as long as language invoker is turned off in any addons settings that uses it, only issue I'm having is the one I've made a new post about but to be honest I'm not sure if it's a skin problem or not

jojobrogess commented 1 year ago

2023-02-06 00_28_37-Addon xml - Official Kodi Wiki โ€” Mozilla Firefox https://kodi.wiki/view/Addon.xml#%3Creuselanguageinvoker%3E 2023-02-06 00_29_39-Addon xml - Official Kodi Wiki โ€” Mozilla Firefox 2023-02-06 00_30_51-Find Results (skin auramod) - Sublime Text (UNREGISTERED)

Hmm, you might be able to get away with just removing that code from the skin?

So change from: <extension point="xbmc.gui.skin" defaultthemename="Textures.xbt" debugging="false" effectslowdown="1"> TO: <extension point="xbmc.gui.skin" defaultthemename="Textures.xbt" debugging="false">

That might make the skin a little wonky though.



Just scanned my whole addon library for languageinvoker. Looks like the only addons that matter, at least to the needs of auramod, are themoviedbhelper plugin/script.

ALTHOUGH, themovidb metadata movie and tv show scrapers also use languageinvoker and those are a big portion of how Kodi works in general.

2023-02-05 23_43_34-Kodi Nexus 20 ยท Issue #276 ยท SerpentDrago_skin auramod โ€” Mozilla Firefox

What happens when you do have that setting on?

JFG1000 commented 1 year ago

If i leave language invoker on i get crashes but if i leave it off I don't, I've been used to having it off for some time now so I'm happy with turning it off, give it a test run yourself with the kodinerds maven version of kodi it runs fine

jojobrogess commented 1 year ago

Looks like there might be a Skinshortcuts issue as well, there have been some updates to the addon: https://github.com/mikesilvo164/script.skinshortcuts

JFG1000 commented 1 year ago

Not really sure what you mean by issues with it, auramod runs fine on the python fix on mavens kodi nerds version of kodi, same fixes will be included with 20.1

jojobrogess commented 1 year ago

There was an issue for Apple Tv Users. Only notes i can see are "[fix] handle missing profiles.xml gracefully (fixes Apple TV)"

It also looks like: script.module.metadatautils script.skin.helper.service script.skin.helper.widgets have been updated for Nexus.

JFG1000 commented 1 year ago

Thanks mate will get it all updated

JFG1000 commented 1 year ago

@jojobrogess got the skin shortcuts update installed, but can't install the other 3 dependencies as it gives me a "can't be satisfied" notification

jojobrogess commented 1 year ago

Metadatautils is a dependent extension in script.skin.helper.service/widgets, so update that PRIOR to updating those and it should work.

JFG1000 commented 1 year ago

Unfortunately it doesn't mate I've already tried

JFG1000 commented 1 year ago

Don't worry sorted it many thanks, could you please let me know if anything else updates for nexus